From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, tariqt@mellanox.com, saeedm@mellanox.com
Subject: Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve
Date: Fri, 20 Jan 2017 12:43:01 -0500 (EST) [thread overview]
Message-ID: <20170120.124301.1228899617504374421.davem@davemloft.net> (raw)
In-Reply-To: <1484809388.16328.19.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 18 Jan 2017 23:03:08 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> A driver using dev_alloc_page() must not reuse a page allocated from
> emergency memory reserve.
>
> Otherwise all packets using this page will be immediately dropped,
> unless for very specific sockets having SOCK_MEMALLOC bit set.
>
> This issue might be hard to debug, because only a fraction of received
> packets would be dropped.
>
> Fixes: 4415a0319f92 ("net/mlx5e: Implement RX mapped page cache for page recycle")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2017-01-20 17:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 7:03 [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve Eric Dumazet
2017-01-19 19:14 ` Saeed Mahameed
2017-01-19 19:25 ` Eric Dumazet
2017-01-19 19:39 ` Saeed Mahameed
2017-01-21 18:09 ` Tom Herbert
[not found] ` <CAPe+=50xs=MMqxHPgTiGa3qytL7633Cygf_vBWuAuq=ceLyacg@mail.gmail.com>
2017-01-21 19:26 ` Eric Dumazet
2017-01-23 9:14 ` Jesper Dangaard Brouer
2017-01-24 9:21 ` Saeed Mahameed
2017-01-21 20:31 ` Saeed Mahameed
2017-01-22 17:50 ` Tom Herbert
2017-01-24 9:29 ` Saeed Mahameed
2017-01-23 8:39 ` Jesper Dangaard Brouer
2017-01-23 15:45 ` David Miller
2017-01-22 18:09 ` Tom Herbert
2017-01-20 10:28 ` Saeed Mahameed
2017-01-20 17:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120.124301.1228899617504374421.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).