From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net v3] bridge: netlink: call br_changelink() during br_dev_newlink() Date: Fri, 20 Jan 2017 15:08:31 -0500 (EST) Message-ID: <20170120.150831.840272160400257097.davem@davemloft.net> References: <20170120171217.20617-1-cera@cera.cz> <20170120181042.GB1784@nanopsycho.orion> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jiri@mellanox.com, cera@cera.cz, bridge@lists.linux-foundation.org To: jiri@resnulli.us Return-path: In-Reply-To: <20170120181042.GB1784@nanopsycho.orion> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org From: Jiri Pirko Date: Fri, 20 Jan 2017 19:10:42 +0100 > Fri, Jan 20, 2017 at 06:12:17PM CET, cera@cera.cz wrote: >>Any bridge options specified during link creation (e.g. ip link add) >>are ignored as br_dev_newlink() does not process them. >>Use br_changelink() to do it. >> >>Fixes: 1332351 ("bridge: implement rtnl_link_ops->changelink") > > Should have 12 chars. Other than that, > > Reviewed-by: Jiri Pirko I fixed up the SHA1-ID. Applied and queued up for -stable, thanks.