From: Stephen Hemminger <stephen@networkplumber.org>
To: Benjamin LaHaise <benjamin.lahaise@netronome.com>
Cc: netdev@vger.kernel.org, bcrl@kvack.org
Subject: Re: [PATCH iproute2] f_flower: don't set TCA_FLOWER_KEY_ETH_TYPE for "protocol all"
Date: Fri, 20 Jan 2017 09:34:45 -0800 [thread overview]
Message-ID: <20170120093445.69306d0b@xeon-e3> (raw)
In-Reply-To: <20170119215159.GA32126@nvt-d.home.kvack.org>
On Thu, 19 Jan 2017 16:51:59 -0500
Benjamin LaHaise <benjamin.lahaise@netronome.com> wrote:
> When using the tc filter flower, rules marked with "protocol all" do not
> actually match all packets. This is due to a bug in f_flower.c that passes
> in ETH_P_ALL in the TCA_FLOWER_KEY_ETH_TYPE attribute when adding a rule.
> Fix this by omitting TCA_FLOWER_KEY_ETH_TYPE if the protocol is set to
> ETH_P_ALL.
>
> Signed-off-by: Benjamin LaHaise <benjamin.lahaise@netronome.com>
> Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
This looks good, but does not apply cleanly to either master or net-next branch
of current repository. Please rebase and resubmit.
It would be helpful to to use Fixes: tag for something which was broken by
a single previous commit.
prev parent reply other threads:[~2017-01-20 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 21:51 [PATCH iproute2] f_flower: don't set TCA_FLOWER_KEY_ETH_TYPE for "protocol all" Benjamin LaHaise
2017-01-20 17:34 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120093445.69306d0b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bcrl@kvack.org \
--cc=benjamin.lahaise@netronome.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).