From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net-next] uapi: fix signess in ethtool_validate_speed() Date: Fri, 20 Jan 2017 18:36:44 +0200 Message-ID: <20170120183606-mutt-send-email-mst@kernel.org> References: <1484918453-5849-1-git-send-email-volodymyr.bendiuga@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, nikolay@cumulusnetworks.com, netdev@vger.kernel.org, volodymyr.bendiuga@westermo.se, Jonas Johansson To: Volodymyr Bendiuga Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44138 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753140AbdATQgq (ORCPT ); Fri, 20 Jan 2017 11:36:46 -0500 Content-Disposition: inline In-Reply-To: <1484918453-5849-1-git-send-email-volodymyr.bendiuga@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Jan 20, 2017 at 02:20:53PM +0100, Volodymyr Bendiuga wrote: > From: Jonas Johansson > > There is a comparison of speed variable which > is unsigned, and SPEED_UNKNOWN which is signed. So? > > Signed-off-by: Jonas Johansson > Signed-off-by: Volodymyr Bendiuga > --- > include/uapi/linux/ethtool.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > index f0db778..1ca4a77 100644 > --- a/include/uapi/linux/ethtool.h > +++ b/include/uapi/linux/ethtool.h > @@ -1500,7 +1500,7 @@ enum ethtool_link_mode_bit_indices { > > #define SPEED_UNKNOWN -1 > > -static inline int ethtool_validate_speed(__u32 speed) > +static inline int ethtool_validate_speed(__s32 speed) > { > return speed <= INT_MAX || speed == SPEED_UNKNOWN; > } Then comparison to INT_MAX does not make sense. > -- > 2.7.4