From: David Miller <davem@davemloft.net>
To: leon@kernel.org
Cc: geliangtang@gmail.com, yishaih@mellanox.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx4: use rb_entry()
Date: Sun, 22 Jan 2017 16:48:47 -0500 (EST) [thread overview]
Message-ID: <20170122.164847.331110749082525627.davem@davemloft.net> (raw)
In-Reply-To: <20170122074839.GD28570@mtr-leonro.local>
From: Leon Romanovsky <leon@kernel.org>
Date: Sun, 22 Jan 2017 09:48:39 +0200
> I don't understand completely the rationale behind this conversion.
> rb_entry == container_of, why do we need another name for it?
Because it's an annotation.
Either you agree that the macro exists and it should be used in
every spot where those types are being used, or you don't and
therefore argue for the macro and it's usage completely.
next prev parent reply other threads:[~2017-01-22 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 14:36 [PATCH] 6lowpan: use rb_entry() Geliang Tang
2017-01-20 14:36 ` [PATCH] net/mlx4: " Geliang Tang
2017-01-22 7:48 ` Leon Romanovsky
2017-01-22 14:42 ` Geliang Tang
2017-01-22 19:05 ` Leon Romanovsky
2017-01-22 21:48 ` David Miller [this message]
2017-01-22 21:48 ` David Miller
2017-01-22 21:47 ` [PATCH] 6lowpan: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170122.164847.331110749082525627.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geliangtang@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).