From: Andrew Lunn <andrew@lunn.ch>
To: Jingju Hou <houjingj@marvell.com>
Cc: davem@davemloft.net, thomas.petazzoni@free-electrons.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: mvneta: implement .set_wol and .get_wol
Date: Sun, 22 Jan 2017 17:49:35 +0100 [thread overview]
Message-ID: <20170122164935.GA26560@lunn.ch> (raw)
In-Reply-To: <1485079590-6392-1-git-send-email-houjingj@marvell.com>
On Sun, Jan 22, 2017 at 06:06:30PM +0800, Jingju Hou wrote:
> Signed-off-by: Jingju Hou <houjingj@marvell.com>
Hi Jingju
Please include a real comment here. Something like:
The mvneta itself does not support WOL, but the PHY might. So pass the
calls to the PHY.
It also looks like you are patching an old kernel. Network patches
like this need to be against net-next. You should also include
net-next in the subject line.
Thanks
Andrew
next prev parent reply other threads:[~2017-01-22 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 10:06 [PATCH] net: mvneta: implement .set_wol and .get_wol Jingju Hou
2017-01-22 11:13 ` kbuild test robot
2017-01-22 11:21 ` kbuild test robot
2017-01-22 16:49 ` Andrew Lunn [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-23 2:43 Jingju Hou
2017-01-23 2:58 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170122164935.GA26560@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=houjingj@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).