From: David Miller <davem@davemloft.net>
To: Joao.Pinto@synopsys.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: stmicro: dwmac4 comments enhancement
Date: Mon, 23 Jan 2017 11:20:42 -0500 (EST) [thread overview]
Message-ID: <20170123.112042.989220998426190929.davem@davemloft.net> (raw)
In-Reply-To: <4b0ae13cd5076f1830bae79e1ad9bd0542d0e2bf.1485186686.git.jpinto@synopsys.com>
From: Joao Pinto <Joao.Pinto@synopsys.com>
Date: Mon, 23 Jan 2017 15:56:24 +0000
> + * This is the driver for the DesignWare Ethernet QoS Controller.
This is fine.
> + * For historical reasons it started in 4.x version.
This provides no value whatsoever.
Please resist the urge to fidget and adjust random things, just get to
the point and make the minimum change necessary to achieve a specific,
well defined, constrained, objective.
Please!
I'm really getting irritated with how much effort is being expended
to make dilly-dally style changes that provide little or no value
to the driver.
Fix bugs and contribute new support for new chips, because this stuff
I'm seeing here is just eating up everyone's time rather than improving
the driver.
Thank you.
prev parent reply other threads:[~2017-01-23 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 15:56 [PATCH net-next] net: stmicro: dwmac4 comments enhancement Joao Pinto
2017-01-23 16:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123.112042.989220998426190929.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).