From: David Miller <davem@redhat.com>
To: timur@codeaurora.org
Cc: netdev@vger.kernel.org, LinoSanfilippo@gmx.de
Subject: Re: [PATCH] [net-next] net: qcom/emac: rename emac_phy to emac_sgmii and move it
Date: Mon, 23 Jan 2017 12:55:02 -0500 (EST) [thread overview]
Message-ID: <20170123.125502.2263699912799183357.davem@redhat.com> (raw)
In-Reply-To: <1484954464-2622-1-git-send-email-timur@codeaurora.org>
From: Timur Tabi <timur@codeaurora.org>
Date: Fri, 20 Jan 2017 17:21:03 -0600
> The EMAC has an internal PHY that is often called the "SGMII". This
> SGMII is also connected to an external PHY, which is managed by phylib.
> These dual PHYs often cause confusion. In this case, the data structure
> for managing the SGMII was mis-named and located in the wrong header file.
>
> Structure emac_phy is renamed to emac_sgmii to clearly indicate it applies
> to the internal PHY only. It also also moved from emac_phy.h (which
> supports the external PHY) to emac_sgmii.h (where it belongs).
>
> To keep the changes minimal, only the structure name is changed, not
> the names of any variables of that type.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
Applied, thanks.
prev parent reply other threads:[~2017-01-23 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 23:21 [PATCH] [net-next] net: qcom/emac: rename emac_phy to emac_sgmii and move it Timur Tabi
2017-01-20 23:21 ` [PATCH] [net-next][v2] net: qcom/emac: claim the irq only when the device is opened Timur Tabi
2017-01-21 22:09 ` Lino Sanfilippo
2017-01-23 18:03 ` David Miller
2017-01-23 17:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123.125502.2263699912799183357.davem@redhat.com \
--to=davem@redhat.com \
--cc=LinoSanfilippo@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).