From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, ramanb@cumulusnetworks.com,
stephen@networkplumber.org, jbenc@redhat.com, pshelar@ovn.org
Subject: Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down
Date: Mon, 23 Jan 2017 16:07:41 -0500 (EST) [thread overview]
Message-ID: <20170123.160741.1558621534864494201.davem@davemloft.net> (raw)
In-Reply-To: <1484984599-16712-2-git-send-email-roopa@cumulusnetworks.com>
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Fri, 20 Jan 2017 23:43:18 -0800
> /* Purge the forwarding table */
> -static void vxlan_flush(struct vxlan_dev *vxlan)
> +static void vxlan_flush(struct vxlan_dev *vxlan, int do_all)
Please use 'bool' and true/false for this new argument.
FWIW, I am fine with changing the default behavior in this way.
next prev parent reply other threads:[~2017-01-23 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 7:43 [PATCH net-next 0/2] vxlan: misc fdb fixes Roopa Prabhu
2017-01-21 7:43 ` [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down Roopa Prabhu
2017-01-23 8:55 ` Jiri Benc
2017-01-23 16:31 ` Roopa Prabhu
2017-01-23 21:07 ` David Miller [this message]
2017-01-24 0:14 ` Roopa Prabhu
2017-01-21 7:43 ` [PATCH net-next 2/2] vxlan: do not age static remote mac entries Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123.160741.1558621534864494201.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=ramanb@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).