netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, yotamg@mellanox.com,
	idosch@mellanox.com, eladr@mellanox.com, nogahf@mellanox.com,
	ogerlitz@mellanox.com, jhs@mojatatu.com, geert+renesas@glider.be,
	xiyou.wangcong@gmail.com, linux@roeck-us.net,
	roopa@cumulusnetworks.com, john.fastabend@gmail.com,
	simon.horman@netronome.com, mrv@mojatatu.com
Subject: Re: [patch net-next 1/4] net: Introduce psample, a new genetlink channel for packet sampling
Date: Mon, 23 Jan 2017 15:57:50 -0800	[thread overview]
Message-ID: <20170123155750.22f4b323@xeon-e3> (raw)
In-Reply-To: <1485085487-2652-2-git-send-email-jiri@resnulli.us>

On Sun, 22 Jan 2017 12:44:44 +0100
Jiri Pirko <jiri@resnulli.us> wrote:

> +static LIST_HEAD(psample_groups_list);
> +static DEFINE_SPINLOCK(psample_groups_lock);
> +

Why not a mutex? You aren't acquiring this in IRQ context?

  parent reply	other threads:[~2017-01-23 23:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-22 11:44 [patch net-next 0/4] Add support for offloading packet-sampling Jiri Pirko
2017-01-22 11:44 ` [patch net-next 1/4] net: Introduce psample, a new genetlink channel for packet sampling Jiri Pirko
2017-01-22 13:19   ` Jamal Hadi Salim
2017-01-23 23:57   ` Stephen Hemminger [this message]
2017-01-24  6:48     ` Jiri Pirko
2017-01-22 11:44 ` [patch net-next 2/4] net/sched: Introduce sample tc action Jiri Pirko
2017-01-22 13:16   ` Jamal Hadi Salim
2017-01-22 13:28     ` Yotam Gigi
2017-01-22 14:29   ` Roman Mashak
2017-01-22 11:44 ` [patch net-next 3/4] mlxsw: reg: add the Monitoring Packet Sampling Configuration Register Jiri Pirko
2017-01-22 11:44 ` [patch net-next 4/4] mlxsw: spectrum: Add packet sample offloading support Jiri Pirko
2017-01-22 12:04   ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123155750.22f4b323@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=davem@davemloft.net \
    --cc=eladr@mellanox.com \
    --cc=geert+renesas@glider.be \
    --cc=idosch@mellanox.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=john.fastabend@gmail.com \
    --cc=linux@roeck-us.net \
    --cc=mrv@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=nogahf@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=simon.horman@netronome.com \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).