From: marcelo.leitner@gmail.com
To: David Miller <davem@davemloft.net>
Cc: David.Laight@ACULAB.COM, lucien.xin@gmail.com,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
nhorman@tuxdriver.com, vyasevich@gmail.com
Subject: Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk
Date: Mon, 23 Jan 2017 14:14:58 -0200 [thread overview]
Message-ID: <20170123161458.GZ3781@localhost.localdomain> (raw)
In-Reply-To: <20170123.110047.447365739282173577.davem@davemloft.net>
On Mon, Jan 23, 2017 at 11:00:47AM -0500, David Miller wrote:
> From: "'Marcelo Ricardo Leitner'" <marcelo.leitner@gmail.com>
> Date: Mon, 23 Jan 2017 10:36:28 -0200
>
> > So, no padding. A field just after the other, which is what we want on a
> > network header.
>
> It isn't necessary!
>
> Show me a case where it is required when you use properly fixed sized
> types and a proper ordering of the struct members. No padding is
> going in there, go and check.
>
> Do we splatter __packed all over our ipv4/ipv6 header, TCP header, UDP
> header, etc. structures? No, we don't because it's totally unecessary.
Err, sure, right.
>
> I will not accept __packed being used unless it is absolutely, provably,
> the only way to solve a particular problem. And when that does happen,
> I am going to require a huge comment explaining in detail why this is
> the case, and why no other approach or solution solved the problem.
Would this be a candidate for checkpatch.pl?
Marcelo
next prev parent reply other threads:[~2017-01-23 16:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 17:19 [PATCHv3 net-next 0/4] sctp: add sender-side procedures for stream reconf asoc reset and add streams Xin Long
2017-01-19 17:19 ` [PATCHv3 net-next 1/4] sctp: add support for generating stream reconf ssn/tsn reset request chunk Xin Long
2017-01-19 17:19 ` [PATCHv3 net-next 2/4] sctp: implement sender-side procedures for SSN/TSN Reset Request Parameter Xin Long
2017-01-19 22:02 ` Marcelo Ricardo Leitner
2017-01-20 8:21 ` Xin Long
2017-01-19 17:19 ` [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk Xin Long
2017-01-20 14:50 ` David Laight
2017-01-20 16:39 ` Marcelo Ricardo Leitner
2017-01-23 12:26 ` David Laight
2017-01-23 12:36 ` 'Marcelo Ricardo Leitner'
2017-01-23 16:00 ` David Miller
2017-01-23 16:14 ` marcelo.leitner [this message]
2017-01-23 16:17 ` David Miller
2017-01-23 15:58 ` David Miller
2017-01-29 14:31 ` marcelo.leitner
2017-01-29 18:41 ` David Miller
2017-01-19 17:19 ` [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter Xin Long
2017-01-19 20:17 ` Neil Horman
2017-01-19 22:18 ` Marcelo Ricardo Leitner
2017-01-23 14:50 ` Neil Horman
2017-01-19 21:47 ` Marcelo Ricardo Leitner
2017-01-20 8:56 ` Xin Long
2017-01-20 11:43 ` Marcelo Ricardo Leitner
2017-01-19 22:15 ` Marcelo Ricardo Leitner
2017-01-20 8:51 ` Xin Long
2017-01-23 11:25 ` David Laight
2017-01-23 14:53 ` Neil Horman
2017-01-23 16:02 ` Marcelo Ricardo Leitner
2017-01-24 12:35 ` David Laight
2017-01-24 13:08 ` 'Marcelo Ricardo Leitner'
2017-01-23 18:47 ` Marcelo Ricardo Leitner
2017-01-24 12:34 ` David Laight
2017-01-24 13:10 ` 'Marcelo Ricardo Leitner'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123161458.GZ3781@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox