netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Charles-Antoine Couret <charles-antoine.couret@nexvision.fr>,
	Clemens Gruber <clemens.gruber@pqgruber.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: marvell: remove conflicting initializer
Date: Mon, 23 Jan 2017 17:28:37 +0100	[thread overview]
Message-ID: <20170123162837.GK10895@lunn.ch> (raw)
In-Reply-To: <7242508.n9OCrlbXLu@wuerfel>

> Great question! I have sent out patches for a couple of actual bugs that
> came from this warning in the past few months.
> 
> I still have a couple of patches that I have not sent out so far,
> I think they are all false-positives, and I have not found a good
> workaround for most of them other than disabling the warning locally.
> 
> Once we get the patches below (or some other workaround) into the
> kernel, we should definitely enable the warning by default.

So it looks like some are from initialising a range of values with
a default value:

[0 ... SH_ETH_MAX_REGISTER_OFFSET - 1] = SH_ETH_OFFSET_INVALID

and then some entries specific values. Maybe the compiler can help out
here? A different warning in this case? And have that at W=1? Could
you ask the gcc folks about this?

Others causes seem like

226 #define DRM_FB_HELPER_DEFAULT_OPS \
227         .fb_check_var   = drm_fb_helper_check_var, \
228         .fb_set_par     = drm_fb_helper_set_par, \
229         .fb_setcmap     = drm_fb_helper_setcmap, \
230         .fb_blank       = drm_fb_helper_blank, \
231         .fb_pan_display = drm_fb_helper_pan_display

static struct fb_ops omap_fb_ops = {
        .owner = THIS_MODULE,
        DRM_FB_HELPER_DEFAULT_OPS,
...
        .fb_pan_display = omap_fbdev_pan_display,

There are at least three drivers which need to replace the
default fb_pan_display. So maybe a different macro?

	Andrew

  reply	other threads:[~2017-01-23 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 12:18 [PATCH] phy: marvell: remove conflicting initializer Arnd Bergmann
2017-01-23 15:19 ` Andrew Lunn
2017-01-23 16:09   ` Arnd Bergmann
2017-01-23 16:28     ` Andrew Lunn [this message]
2017-01-24 19:09 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123162837.GK10895@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=charles-antoine.couret@nexvision.fr \
    --cc=clemens.gruber@pqgruber.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).