From: David Miller <davem@davemloft.net>
To: yotamg@mellanox.com
Cc: mlxsw@mellanox.com, jiri@mellanox.com, eladr@mellanox.com,
daniel@iogearbox.net, jhs@mojatatu.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net/sched: matchall: Fix configuration race
Date: Tue, 24 Jan 2017 13:42:04 -0500 (EST) [thread overview]
Message-ID: <20170124.134204.1815559887565233291.davem@davemloft.net> (raw)
In-Reply-To: <1485161667-13929-1-git-send-email-yotamg@mellanox.com>
From: Yotam Gigi <yotamg@mellanox.com>
Date: Mon, 23 Jan 2017 10:54:27 +0200
> In the current version, the matchall internal state is split into two
> structs: cls_matchall_head and cls_matchall_filter. This makes little
> sense, as matchall instance supports only one filter, and there is no
> situation where one exists and the other does not. In addition, that led
> to some races when filter was deleted while packet was processed.
>
> Unify that two structs into one, thus simplifying the process of matchall
> creation and deletion. As a result, the new, delete and get callbacks have
> a dummy implementation where all the work is done in destroy and change
> callbacks, as was done in cls_cgroup.
>
> Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier")
> Signed-off-by: Yotam Gigi <yotamg@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
This doesn't apply cleanly to the net tree, please respin.
prev parent reply other threads:[~2017-01-24 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 8:54 [PATCH net] net/sched: matchall: Fix configuration race Yotam Gigi
2017-01-24 18:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124.134204.1815559887565233291.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=eladr@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox