From: David Miller <davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: andrew@lunn.ch, netdev@vger.kernel.org, f.fainelli@gmail.com
Subject: Re: [PATCH net-next 0/5] External MDIO support for mv88e6xxx
Date: Tue, 24 Jan 2017 16:07:50 -0500 (EST) [thread overview]
Message-ID: <20170124.160750.354090492587505672.davem@davemloft.net> (raw)
In-Reply-To: <874m0odv97.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Tue, 24 Jan 2017 16:05:08 -0500
> Hi David,
>
> David Miller <davem@davemloft.net> writes:
>
>> Series applied, thanks Andrew.
>>
>> There seems to be a bit of inconsistency wrt. tab vs. space for
>> indentation in the binding files, just FYI. I had to make some small
>> adjustments to this patch series in order to keep GIT from warning
>> when I applied this stuff.
>
> Andrew just replied to my comment an hour ago, and I still have concerns
> about the patchset. I didn't like the list_head of busses, and the 6352
> family don't support the external mode. That needed to be addressed.
>
> Why such an hurry to merge patches?
Because my backlog sucks otherwise?
I can revert, or you can ask Andrew to post follow-on fixups to
satisfy your concerns. Just because I applied it doesn't make it
the end of the world.
And maybe I should apply patches aggressively, as this lights a fire
under everyone's butt and people review and fix things more quickly.
:-)
next prev parent reply other threads:[~2017-01-24 21:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 13:53 [PATCH net-next 0/5] External MDIO support for mv88e6xxx Andrew Lunn
2017-01-24 13:53 ` [PATCH net-next 1/5] net: dsa: mv88e6xxx: Abstract mv88e6165 PHY operations Andrew Lunn
2017-01-24 15:56 ` Vivien Didelot
2017-01-24 13:53 ` [PATCH net-next 2/5] net: dsa: mv88e6xxx: Pass mii_bus to all " Andrew Lunn
2017-01-24 13:53 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: Add mdio private structure Andrew Lunn
2017-01-24 13:53 ` [PATCH net-next 4/5] net: dsa: mv88e6xxx: Support multiple MDIO busses Andrew Lunn
2017-01-24 13:53 ` [PATCH net-next 5/5] net: dsa: mv88e6xxx: Implement the 6390 external MDIO bus Andrew Lunn
2017-01-24 17:48 ` Vivien Didelot
2017-01-24 19:54 ` Andrew Lunn
2017-01-25 1:32 ` Andrew Lunn
2017-01-25 8:13 ` Gregory CLEMENT
2017-01-24 20:35 ` [PATCH net-next 0/5] External MDIO support for mv88e6xxx David Miller
2017-01-24 21:05 ` Vivien Didelot
2017-01-24 21:07 ` David Miller [this message]
2017-01-24 21:11 ` David Miller
2017-01-24 21:24 ` Vivien Didelot
2017-01-24 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124.160750.354090492587505672.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).