From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: John Fastabend <john.fastabend@gmail.com>,
jasowang@redhat.com, john.r.fastabend@intel.com,
netdev@vger.kernel.org, daniel@iogearbox.net
Subject: Re: XDP offload to hypervisor
Date: Tue, 24 Jan 2017 06:35:58 +0200 [thread overview]
Message-ID: <20170124063507-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170124035029.GA89215@ast-mbp.thefacebook.com>
On Mon, Jan 23, 2017 at 07:50:31PM -0800, Alexei Starovoitov wrote:
> On Tue, Jan 24, 2017 at 05:33:37AM +0200, Michael S. Tsirkin wrote:
> > On Mon, Jan 23, 2017 at 05:02:02PM -0800, Alexei Starovoitov wrote:
> > > Frankly I don't understand the whole virtio nit picking that was happening.
> > > imo virtio+xdp by itself is only useful for debugging, development and testing
> > > of xdp programs in a VM. The discussion about performance of virtio+xdp
> > > will only be meaningful when corresponding host part is done.
> > > Likely in the form of vhost extensions and may be driver changes.
> > > Trying to optimize virtio+xdp when host is doing traditional skb+vhost
> > > isn't going to be impactful.
> >
> > Well if packets can be dropped without a host/guest
> > transition then yes, that will have an impact even
> > with traditional skbs.
>
> I don't think it's worth optimizing for though, since the speed of drop
> matters for ddos-like use case
It's not just drops. adjust head + xmit can handle bridging
without entering the VM.
> and if we let host be flooded with skbs,
> we already lost, since the only thing cpu is doing is allocating skbs
> and moving them around. Whether drop is happening upon entry into VM
> or host does it in some post-vhost layer doesn't change the picture much.
> That said, I do like the idea of offloading virto+xdp into host somehow.
next prev parent reply other threads:[~2017-01-24 4:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 21:40 XDP offload to hypervisor Michael S. Tsirkin
2017-01-23 21:56 ` John Fastabend
2017-01-23 22:26 ` Michael S. Tsirkin
2017-01-25 2:45 ` Jason Wang
2017-01-25 3:17 ` Michael S. Tsirkin
2017-01-24 1:02 ` Alexei Starovoitov
2017-01-24 2:47 ` Michael S. Tsirkin
2017-01-24 3:33 ` Michael S. Tsirkin
2017-01-24 3:50 ` Alexei Starovoitov
2017-01-24 4:35 ` Michael S. Tsirkin [this message]
2017-01-25 2:51 ` Jason Wang
2017-01-25 3:03 ` Jason Wang
2017-01-25 2:41 ` Jason Wang
2017-01-25 3:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124063507-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).