From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [patch net-next] sctp: fix some debug output Date: Tue, 24 Jan 2017 07:14:11 -0200 Message-ID: <20170124091411.GE3781@localhost.localdomain> References: <20170124090540.GA27652@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vlad Yasevich , Xin Long , Neil Horman , "David S. Miller" , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, Colin King To: Dan Carpenter Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37486 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbdAXJOR (ORCPT ); Tue, 24 Jan 2017 04:14:17 -0500 Content-Disposition: inline In-Reply-To: <20170124090540.GA27652@mwanda> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 24, 2017 at 12:05:40PM +0300, Dan Carpenter wrote: > We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so > it causes an off-by-one read overflow. > > Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer") > Signed-off-by: Dan Carpenter Weird, seems your patch is missing the --- marker here. Colin (Cc'ed) is supposed to post a v3 of his patch containing this fix. > > diff --git a/net/sctp/debug.c b/net/sctp/debug.c > index 95d7b15dad21..c5f4ed5242ac 100644 > --- a/net/sctp/debug.c > +++ b/net/sctp/debug.c > @@ -159,6 +159,7 @@ static const char *const sctp_timer_tbl[] = { > "TIMEOUT_T4_RTO", > "TIMEOUT_T5_SHUTDOWN_GUARD", > "TIMEOUT_HEARTBEAT", > + "TIMEOUT_RECONF", > "TIMEOUT_SACK", > "TIMEOUT_AUTOCLOSE", > }; > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >