From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch net-next] sctp: fix some debug output Date: Tue, 24 Jan 2017 13:50:07 +0300 Message-ID: <20170124105007.GF4201@mwanda> References: <20170124090540.GA27652@mwanda> <20170124091411.GE3781@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vlad Yasevich , Xin Long , Neil Horman , "David S. Miller" , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, Colin King To: Marcelo Ricardo Leitner Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:42095 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdAXKvV (ORCPT ); Tue, 24 Jan 2017 05:51:21 -0500 Content-Disposition: inline In-Reply-To: <20170124091411.GE3781@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 24, 2017 at 07:14:11AM -0200, Marcelo Ricardo Leitner wrote: > On Tue, Jan 24, 2017 at 12:05:40PM +0300, Dan Carpenter wrote: > > We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so > > it causes an off-by-one read overflow. > > > > Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer") > > Signed-off-by: Dan Carpenter > > Weird, seems your patch is missing the --- marker here. Are there tools that require the --- marker? I normally leave it out when it's not required. regards, dan carpenter