From: Andreas Schultz <aschultz@tpip.net>
To: Pablo Neira <pablo@netfilter.org>
Cc: netdev@vger.kernel.org,
Lionel Gauthier <Lionel.Gauthier@eurecom.fr>,
openbsc@lists.osmocom.org, Harald Welte <laforge@gnumonks.org>
Subject: [PATCH v2 13/18] gtp: replace netdev_dbg and KERN_DEBUG printk with pr_debug
Date: Tue, 24 Jan 2017 16:28:43 +0100 [thread overview]
Message-ID: <20170124152848.6120-14-aschultz@tpip.net> (raw)
In-Reply-To: <20170124152848.6120-1-aschultz@tpip.net>
pr_debug is more versatile for normal debugging.
Also replace netdev_dbg in in places where the network device
will be remove soon.
Signed-off-by: Andreas Schultz <aschultz@tpip.net>
---
drivers/net/gtp.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index 8d74b7d..7d82252 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -235,7 +235,7 @@ static int gtp0_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb)
pctx = gtp0_pdp_find(gtp, be64_to_cpu(gtp0->tid));
if (IS_ERR(pctx)) {
- netdev_dbg(gtp->dev, "No PDP ctx to decap skb=%p\n", skb);
+ pr_debug("No PDP ctx to decap skb=%p\n", skb);
return 1;
}
@@ -277,7 +277,7 @@ static int gtp1u_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb)
pctx = gtp1_pdp_find(gtp, ntohl(gtp1->tid));
if (IS_ERR(pctx)) {
- netdev_dbg(gtp->dev, "No PDP ctx to decap skb=%p\n", skb);
+ pr_debug("No PDP ctx to decap skb=%p\n", skb);
return 1;
}
@@ -296,15 +296,15 @@ static int gtp_encap_recv(struct sock *sk, struct sk_buff *skb)
if (!gtp)
return 1;
- netdev_dbg(gtp->dev, "encap_recv sk=%p\n", sk);
+ pr_debug("encap_recv sk=%p\n", sk);
switch (udp_sk(sk)->encap_type) {
case UDP_ENCAP_GTP0:
- netdev_dbg(gtp->dev, "received GTP0 packet\n");
+ pr_debug("received GTP0 packet\n");
ret = gtp0_udp_encap_recv(gtp, skb);
break;
case UDP_ENCAP_GTP1U:
- netdev_dbg(gtp->dev, "received GTP1U packet\n");
+ pr_debug("received GTP1U packet\n");
ret = gtp1u_udp_encap_recv(gtp, skb);
break;
default:
@@ -313,12 +313,12 @@ static int gtp_encap_recv(struct sock *sk, struct sk_buff *skb)
switch (ret) {
case 1:
- netdev_dbg(gtp->dev, "pass up to the process\n");
+ pr_debug("pass up to the process\n");
break;
case 0:
break;
case -1:
- netdev_dbg(gtp->dev, "GTP packet has been dropped\n");
+ pr_debug("GTP packet has been dropped\n");
kfree_skb(skb);
ret = 0;
break;
--
2.10.2
next prev parent reply other threads:[~2017-01-24 15:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 15:28 [PATCH v2 00/18] gtp: fixes and support multiple VRF's per GTP socket Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 01/18] gtp: add genl family modules alias Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 02/18] gtp: clear DF bit on GTP packet tx Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 03/18] gtp: make GTP sockets in gtp_newlink optional Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 04/18] gtp: return error ptr in find pdp helpers Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 05/18] gtp: unify genl_find_pdp and prepare for per socket lookup Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 06/18] gtp: fix cross netns recv on gtp socket Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 07/18] gtp: remove unnecessary rcu_read_lock Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 08/18] gtp: consolidate pdp context destruction into helper Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 09/18] gtp: use addr_hash when traversing pdp contexts Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 10/18] gtp: add socket to pdp context Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 11/18] gtp: consolidate gtp socket rx path Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 12/18] gtp: let userspace handle packets for invalid tunnels Andreas Schultz
2017-01-24 15:28 ` Andreas Schultz [this message]
2017-01-24 15:28 ` [PATCH v2 14/18] gtp: move TEID hash to per socket structure Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 15/18] gtp: rename gtp hashtable helpers Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 16/18] gtp: add genl cmd to enable GTP encapsulation on UDP socket Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 17/18] gtp: add support to select a GTP socket during PDP context creation Andreas Schultz
2017-01-24 15:28 ` [PATCH v2 18/18] gtp: add dst_cache support Andreas Schultz
2017-01-24 15:39 ` [PATCH v2 00/18] gtp: fixes and support multiple VRF's per GTP socket Harald Welte
2017-01-24 16:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124152848.6120-14-aschultz@tpip.net \
--to=aschultz@tpip.net \
--cc=Lionel.Gauthier@eurecom.fr \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
--cc=openbsc@lists.osmocom.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).