From: Willy Tarreau <w@1wt.eu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Yuchung Cheng <ycheng@google.com>, Wei Wang <tracywwnj@gmail.com>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>, Wei Wang <weiwan@google.com>
Subject: Re: [PATCH net-next 3/3] net/tcp-fastopen: Add new API support
Date: Tue, 24 Jan 2017 19:43:45 +0100 [thread overview]
Message-ID: <20170124184345.GF21921@1wt.eu> (raw)
In-Reply-To: <1485279727.16328.303.camel@edumazet-glaptop3.roam.corp.google.com>
On Tue, Jan 24, 2017 at 09:42:07AM -0800, Eric Dumazet wrote:
> On Tue, 2017-01-24 at 09:26 -0800, Yuchung Cheng wrote:
>
> > >
> > > Do you think there's a compelling reason for adding a new option or
> > > are you interested in a small patch to perform the change above ?
> > I like the proposal especially other stack also uses TCP_FASTOPEN
> > https://msdn.microsoft.com/en-us/library/windows/desktop/ms738596(v=vs.85).aspx
>
>
> Problem is that might break existing applications that were using
> TCP_FASTOPEN before a connect() (it was a NOP until now)
>
> I prefer we use a separate new option to be 100% safe, not adding
> regressions.
>
> Only new applications, tested, will use this new feature at their risk.
That's indeed a good point. I Yuchung's comment above made me wonder
about application's portability but very few OSes will use this and in
the end it might be that portable applications will just add :
#define TCP_FASTOPEN_CONNECT TCP_FASTOPEN
For other OSes and use TCP_FASTOPEN_CONNECT only for the connect() case.
Willy
next prev parent reply other threads:[~2017-01-24 18:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 18:59 [PATCH net-next 0/3] net/tcp-fastopen: Add new userspace API support Wei Wang
2017-01-23 18:59 ` [PATCH net-next 1/3] net/tcp-fastopen: refactor cookie check logic Wei Wang
2017-01-23 19:13 ` Eric Dumazet
2017-01-23 20:51 ` Yuchung Cheng
2017-01-23 18:59 ` [PATCH net-next 2/3] net: Remove __sk_dst_reset() in tcp_v6_connect() Wei Wang
2017-01-23 19:14 ` Eric Dumazet
2017-01-23 18:59 ` [PATCH net-next 3/3] net/tcp-fastopen: Add new API support Wei Wang
2017-01-23 19:15 ` Eric Dumazet
2017-01-23 20:55 ` Yuchung Cheng
2017-01-23 21:16 ` Willy Tarreau
[not found] ` <CAEA6p_DxVMAry1PCz_idmk=TGpnnTib3WpWso03FB1oMVXN+sg@mail.gmail.com>
2017-01-23 21:37 ` Willy Tarreau
2017-01-23 22:01 ` Willy Tarreau
2017-01-23 22:33 ` Willy Tarreau
[not found] ` <CAC15z3g8OxZNET+OnvcyYwHYuHq7QBamgGmjkBHzDr-XnUSGDQ@mail.gmail.com>
2017-01-23 23:01 ` Willy Tarreau
2017-01-24 17:44 ` Eric Dumazet
2017-01-24 18:34 ` Willy Tarreau
2017-01-24 18:51 ` Eric Dumazet
2017-01-24 19:11 ` Willy Tarreau
[not found] ` <CAC15z3izWNh7th_yxA_a90vgLnU5XzVDm6vyojq3cMDgQZ71YA@mail.gmail.com>
2017-01-25 17:22 ` David Miller
2017-01-25 17:54 ` Willy Tarreau
2017-01-25 18:54 ` Wei Wang
2017-01-25 19:03 ` Eric Dumazet
2017-01-25 19:03 ` David Miller
2017-01-25 19:30 ` Wei Wang
2017-01-25 17:53 ` Willy Tarreau
2017-01-24 7:30 ` Willy Tarreau
2017-01-24 17:26 ` Yuchung Cheng
2017-01-24 17:42 ` Eric Dumazet
2017-01-24 18:43 ` Willy Tarreau [this message]
2017-01-25 19:09 ` [PATCH net-next 0/3] net/tcp-fastopen: Add new userspace " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124184345.GF21921@1wt.eu \
--to=w@1wt.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tracywwnj@gmail.com \
--cc=weiwan@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).