From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jbaron@akamai.com, netdev@vger.kernel.org, oleg@redhat.com
Subject: Re: [PATCH net] tcp: correct memory barrier usage in tcp_check_space()
Date: Wed, 25 Jan 2017 13:23:49 -0500 (EST) [thread overview]
Message-ID: <20170125.132349.547836653319181331.davem@davemloft.net> (raw)
In-Reply-To: <1485320017.16328.386.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 24 Jan 2017 20:53:37 -0800
> On Tue, 2017-01-24 at 21:49 -0500, Jason Baron wrote:
>> From: Jason Baron <jbaron@akamai.com>
>>
>> sock_reset_flag() maps to __clear_bit() not the atomic version clear_bit().
>> Thus, we need smp_mb(), smp_mb__after_atomic() is not sufficient.
>>
>> Fixes: 3c7151275c0c ("tcp: add memory barriers to write space paths")
>> Cc: Eric Dumazet <eric.dumazet@gmail.com>
>> Cc: Oleg Nesterov <oleg@redhat.com>
>> Signed-off-by: Jason Baron <jbaron@akamai.com>
>> ---
>> net/ipv4/tcp_input.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Eric Dumazet <edumazet@google.com>
>
> I believe this would need also this for proper attribution.
>
> Reported-by: Oleg Nesterov <oleg@redhat.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2017-01-25 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 2:49 [PATCH net] tcp: correct memory barrier usage in tcp_check_space() Jason Baron
2017-01-25 4:53 ` Eric Dumazet
2017-01-25 18:23 ` David Miller [this message]
2017-02-04 9:59 ` Herbert Xu
2017-02-04 15:19 ` Eric Dumazet
2017-02-04 15:57 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125.132349.547836653319181331.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jbaron@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox