From: Andrew Lunn <andrew@lunn.ch>
To: Gregory Clement <gregory.clement@free-electrons.com>
Cc: netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: Implement the 6390 external MDIO bus
Date: Wed, 25 Jan 2017 02:32:30 +0100 [thread overview]
Message-ID: <20170125013230.GB5043@lunn.ch> (raw)
In-Reply-To: <1485266031-4980-6-git-send-email-andrew@lunn.ch>
> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> index 7d24add45e74..572d585dc1e2 100644
> --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> @@ -387,6 +387,7 @@
> #define GLOBAL2_PTP_AVB_DATA 0x17
> #define GLOBAL2_SMI_PHY_CMD 0x18
> #define GLOBAL2_SMI_PHY_CMD_BUSY BIT(15)
> +#define GLOBAL2_SMI_PHY_CMD_EXTERNAL BIT(13)
> #define GLOBAL2_SMI_PHY_CMD_MODE_22 BIT(12)
> #define GLOBAL2_SMI_PHY_CMD_OP_22_WRITE_DATA ((0x1 << 10) | \
Hi Gregory
Please could you check if the 88E6341 has an external MDIO. Global 2,
register 0x18, bit 13.
Thanks
Andrew
next prev parent reply other threads:[~2017-01-25 1:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 13:53 [PATCH net-next 0/5] External MDIO support for mv88e6xxx Andrew Lunn
2017-01-24 13:53 ` [PATCH net-next 1/5] net: dsa: mv88e6xxx: Abstract mv88e6165 PHY operations Andrew Lunn
2017-01-24 15:56 ` Vivien Didelot
2017-01-24 13:53 ` [PATCH net-next 2/5] net: dsa: mv88e6xxx: Pass mii_bus to all " Andrew Lunn
2017-01-24 13:53 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: Add mdio private structure Andrew Lunn
2017-01-24 13:53 ` [PATCH net-next 4/5] net: dsa: mv88e6xxx: Support multiple MDIO busses Andrew Lunn
2017-01-24 13:53 ` [PATCH net-next 5/5] net: dsa: mv88e6xxx: Implement the 6390 external MDIO bus Andrew Lunn
2017-01-24 17:48 ` Vivien Didelot
2017-01-24 19:54 ` Andrew Lunn
2017-01-25 1:32 ` Andrew Lunn [this message]
2017-01-25 8:13 ` Gregory CLEMENT
2017-01-24 20:35 ` [PATCH net-next 0/5] External MDIO support for mv88e6xxx David Miller
2017-01-24 21:05 ` Vivien Didelot
2017-01-24 21:07 ` David Miller
2017-01-24 21:11 ` David Miller
2017-01-24 21:24 ` Vivien Didelot
2017-01-24 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125013230.GB5043@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).