From: Andrew Lunn <andrew@lunn.ch>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "David S. Miller" <davem@davemloft.net>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Zach Brown" <zach.brown@ni.com>,
"Volodymyr Bendiuga" <volodymyr.bendiuga@gmail.com>,
"Magnus Öberg" <magnus.oberg@westermo.se>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] net: phy: leds: Break dependency of phy.h on phy_led_triggers.h
Date: Wed, 25 Jan 2017 13:50:46 +0100 [thread overview]
Message-ID: <20170125125046.GA2504@lunn.ch> (raw)
In-Reply-To: <1485340790-10785-3-git-send-email-geert+renesas@glider.be>
On Wed, Jan 25, 2017 at 11:39:49AM +0100, Geert Uytterhoeven wrote:
> <linux/phy.h> includes <linux/phy_led_triggers.h>, which is not really
> needed. Drop the include from <linux/phy.h>, and add it to all users
> that didn't include it explicitly.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-01-25 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 10:39 [PATCH v2 0/3] net: phy: leds: Fix truncated LED trigger names and crashes Geert Uytterhoeven
2017-01-25 10:39 ` [PATCH v2 1/3] net: phy: leds: Clear phy_num_led_triggers on failure to avoid crash Geert Uytterhoeven
2017-01-25 10:39 ` [PATCH v2 2/3] net: phy: leds: Break dependency of phy.h on phy_led_triggers.h Geert Uytterhoeven
2017-01-25 12:50 ` Andrew Lunn [this message]
2017-01-25 10:39 ` [PATCH v2 3/3] net: phy: leds: Fix truncated LED trigger names Geert Uytterhoeven
2017-01-25 12:51 ` Andrew Lunn
2017-01-25 19:40 ` [PATCH v2 0/3] net: phy: leds: Fix truncated LED trigger names and crashes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125125046.GA2504@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.oberg@westermo.se \
--cc=netdev@vger.kernel.org \
--cc=volodymyr.bendiuga@gmail.com \
--cc=zach.brown@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).