From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Andreas Schultz <aschultz@tpip.net>
Cc: netdev@vger.kernel.org,
Lionel Gauthier <Lionel.Gauthier@eurecom.fr>,
openbsc@lists.osmocom.org, Harald Welte <laforge@gnumonks.org>
Subject: Re: [PATCH net v2 3/3] gtp: fix cross netns recv on gtp socket
Date: Thu, 26 Jan 2017 16:34:40 +0100 [thread overview]
Message-ID: <20170126153440.GC1763@salvia> (raw)
In-Reply-To: <20170126151134.2892-4-aschultz@tpip.net>
On Thu, Jan 26, 2017 at 04:11:34PM +0100, Andreas Schultz wrote:
> The use of the passed through netlink src_net to check for a
> cross netns operation was wrong. Using the GTP socket and the
> GTP netdevice is always correct (even if the netdev has been
> moved to new netns after link creation).
>
> Remove the now obsolete net field from gtp_dev.
>
> Signed-off-by: Andreas Schultz <aschultz@tpip.net>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
next prev parent reply other threads:[~2017-01-26 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 15:11 [PATCH net v2 0/3] various gtp fixes Andreas Schultz
2017-01-26 15:11 ` [PATCH net v2 1/3] gtp: add genl family modules alias Andreas Schultz
2017-01-26 15:34 ` Pablo Neira Ayuso
2017-01-26 15:11 ` [PATCH net v2 2/3] gtp: clear DF bit on GTP packet tx Andreas Schultz
2017-01-26 15:34 ` [PATCH net v2 2/3] gtp: clear DF bit on GTP packet txç Pablo Neira Ayuso
2017-01-26 15:11 ` [PATCH net v2 3/3] gtp: fix cross netns recv on gtp socket Andreas Schultz
2017-01-26 15:34 ` Pablo Neira Ayuso [this message]
2017-01-26 19:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126153440.GC1763@salvia \
--to=pablo@netfilter.org \
--cc=Lionel.Gauthier@eurecom.fr \
--cc=aschultz@tpip.net \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
--cc=openbsc@lists.osmocom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).