From: Jiri Pirko <jiri@resnulli.us>
To: Phil Sutter <phil@nwl.cc>
Cc: Stephen Hemminger <stephen@networkplumber.org>, netdev@vger.kernel.org
Subject: Re: [iproute PATCH] man: tc-csum.8: Fix example
Date: Fri, 27 Jan 2017 13:26:06 +0100 [thread overview]
Message-ID: <20170127122606.GA2386@nanopsycho> (raw)
In-Reply-To: <20170127111501.21439-1-phil@nwl.cc>
Fri, Jan 27, 2017 at 12:15:01PM CET, phil@nwl.cc wrote:
>This fixes two issues with the provided example:
>
>- Add missing 'dev' keyword to second command.
>- Use a real IPv4 address instead of a bogus hex value since that will
> be rejected by get_addr_ipv4().
>
>Fixes: dbfb17a67f9c7 ("man: tc-csum.8: Add an example")
>Reported-by: Davide Caratti <dcaratti@redhat.com>
>Signed-off-by: Phil Sutter <phil@nwl.cc>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2017-01-27 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 11:15 [iproute PATCH] man: tc-csum.8: Fix example Phil Sutter
2017-01-27 12:26 ` Jiri Pirko [this message]
2017-01-27 20:49 ` Guillaume Nault
2017-01-28 11:16 ` Phil Sutter
2017-01-30 12:12 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127122606.GA2386@nanopsycho \
--to=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).