From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin King Subject: [PATCH][next-next] net: ethernet: aquantia: return -ETIME in macro AQ_HW_WAIT_FOR Date: Fri, 27 Jan 2017 15:06:46 +0000 Message-ID: <20170127150646.19181-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: "David S . Miller" , Pavel Belous , Alexander Loktionov , Dmitry Bezrukov , David VomLehn , netdev@vger.kernel.org Return-path: Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin Ian King The macro is returning ETIME which means various checks to see if the returned err is less than zero never work. I believe a -ETIME should be returned instead. Signed-off-by: Colin Ian King --- drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h b/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h index 78fcc0c..03b72dd 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h +++ b/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h @@ -31,7 +31,7 @@ do { \ udelay(_US_); \ } \ if (!AQ_HW_WAIT_FOR_i) {\ - err = ETIME; \ + err = -ETIME; \ } \ } while (0) -- 2.10.2