From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] Documentation: devicetree: change the mediatek ethernet compatible string Date: Fri, 27 Jan 2017 16:41:05 -0600 Message-ID: <20170127224105.e6di34pd3dwgn2hr@rob-hp-laptop> References: <1485332455-34743-1-git-send-email-john@phrozen.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Matthias Brugger , "David S. Miller" , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sean Wang , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: John Crispin Return-path: Content-Disposition: inline In-Reply-To: <1485332455-34743-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Wed, Jan 25, 2017 at 09:20:54AM +0100, John Crispin wrote: > When the binding was defined, I was not aware that mt2701 was an earlier > version of the SoC. For sake of consistency, the ethernet driver should > use mt2701 inside the compat string as this is the earliest SoC with the > ethernet core. > > The ethernet driver is currently of no real use until we finish and > upstream the DSA driver. There are no users of this binding yet. It should > be safe to fix this now before it is too late and we need to provide > backward compatibility for the mt7623-eth compat string. Thanks for the explanation. > Reported-by: Sean Wang > Signed-off-by: John Crispin > --- > Documentation/devicetree/bindings/net/mediatek-net.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt > index c010faf..c7194e8 100644 > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt > @@ -7,7 +7,7 @@ have dual GMAC each represented by a child node.. > * Ethernet controller node > > Required properties: > -- compatible: Should be "mediatek,mt7623-eth" > +- compatible: Should be "mediatek,mt2701-eth" You should have both strings with 2701 being last. That way if you ever find a difference in the 7623, you don't need a DT update to fix it. > - reg: Address and length of the register set for the device > - interrupts: Should contain the three frame engines interrupts in numeric > order. These are fe_int0, fe_int1 and fe_int2. > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html