From: Phil Sutter <phil@nwl.cc>
To: Guillaume Nault <g.nault@alphalink.fr>
Cc: Stephen Hemminger <stephen@networkplumber.org>, netdev@vger.kernel.org
Subject: Re: [iproute PATCH] man: tc-csum.8: Fix example
Date: Sat, 28 Jan 2017 12:16:48 +0100 [thread overview]
Message-ID: <20170128111648.GX5197@orbyte.nwl.cc> (raw)
In-Reply-To: <20170127204958.uo5ssloejdirohsj@alphalink.fr>
On Fri, Jan 27, 2017 at 09:49:58PM +0100, Guillaume Nault wrote:
> On Fri, Jan 27, 2017 at 12:15:01PM +0100, Phil Sutter wrote:
> > +# tc filter add dev eth0 prio 1 protocol ip parent ffff: \\
> > u32 match ip src 192.168.1.100/32 flowid :1 \\
> > - action pedit munge ip dst set 0x12345678 pipe \\
> > + action pedit munge ip dst set 1.2.3.4 pipe \\
> >
> Just nitpicking here, but IMHO examples like this should better use IP
> addresses reserved for documentation (192.0.2.0/24, 198.51.100.0/24 or
> 203.0.113.0/24).
Good point! This wasn't on my radar yet and I didn't know there were
IPv4 ranges specifically for that purpose. I guess the reasoning here is
analogous to why one shouldn't use 'example.com' everywhere.
Luckily, 1.2.3.0/24 seems to be reserved by APNIC for testing purposes.
:)
I'll respin using another example address.
Thanks, Phil
next prev parent reply other threads:[~2017-01-28 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 11:15 [iproute PATCH] man: tc-csum.8: Fix example Phil Sutter
2017-01-27 12:26 ` Jiri Pirko
2017-01-27 20:49 ` Guillaume Nault
2017-01-28 11:16 ` Phil Sutter [this message]
2017-01-30 12:12 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170128111648.GX5197@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=g.nault@alphalink.fr \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).