From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH][next-next] net: ethernet: aquantia: return -ETIME in macro AQ_HW_WAIT_FOR Date: Sun, 29 Jan 2017 18:24:27 -0500 (EST) Message-ID: <20170129.182427.1212745842603180686.davem@davemloft.net> References: <20170127150646.19181-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Pavel.Belous@aquantia.com, Alexander.Loktionov@aquantia.com, Dmitry.Bezrukov@aquantia.com, vomlehn@texas.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20170127150646.19181-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Fri, 27 Jan 2017 15:06:46 +0000 > From: Colin Ian King > > The macro is returning ETIME which means various checks to see if > the returned err is less than zero never work. I believe a -ETIME > should be returned instead. > > Signed-off-by: Colin Ian King Applied.