From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: socketcan@hartkopp.net, shuo.a.liu@intel.com,
yanmin_zhang@linux.intel.com, shuox.liu@gmail.com,
yanmin.zhang@intel.com, bo.he@intel.com, mkl@pengutronix.de,
linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3] can: Fix kernel panic at security_sock_rcv_skb
Date: Sun, 29 Jan 2017 18:34:06 -0500 (EST) [thread overview]
Message-ID: <20170129.183406.1410276231781823069.davem@davemloft.net> (raw)
In-Reply-To: <1485533504.6360.62.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 27 Jan 2017 08:11:44 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Zhang Yanmin reported crashes [1] and provided a patch adding a
> synchronize_rcu() call in can_rx_unregister()
>
> The main problem seems that the sockets themselves are not RCU
> protected.
>
> If CAN uses RCU for delivery, then sockets should be freed only after
> one RCU grace period.
>
> Recent kernels could use sock_set_flag(sk, SOCK_RCU_FREE), but let's
> ease stable backports with the following fix instead.
...
> Reported-by: Zhang Yanmin <yanmin.zhang@intel.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks Eric.
next prev parent reply other threads:[~2017-01-29 23:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 6:33 [PATCH] can: Fix kernel panic at security_sock_rcv_skb Liu ShuoX
2017-01-12 8:22 ` Oliver Hartkopp
2017-01-12 13:01 ` Eric Dumazet
2017-01-12 16:33 ` Oliver Hartkopp
2017-01-14 3:43 ` Liu Shuo
2017-01-14 13:53 ` Oliver Hartkopp
2017-01-14 17:30 ` Eric Dumazet
2017-01-27 16:11 ` [PATCH v3] " Eric Dumazet
2017-01-27 20:02 ` Oliver Hartkopp
2017-01-29 23:34 ` David Miller [this message]
2017-02-10 8:28 ` Oliver Hartkopp
2017-02-10 15:16 ` David Miller
2017-02-10 17:50 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170129.183406.1410276231781823069.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bo.he@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=shuo.a.liu@intel.com \
--cc=shuox.liu@gmail.com \
--cc=socketcan@hartkopp.net \
--cc=yanmin.zhang@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).