From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH v2] man: tc-csum.8: Fix example
Date: Sun, 29 Jan 2017 20:26:09 -0800 [thread overview]
Message-ID: <20170129202609.6b2521a0@xeon-e3> (raw)
In-Reply-To: <20170128115910.1127-1-phil@nwl.cc>
On Sat, 28 Jan 2017 12:59:10 +0100
Phil Sutter <phil@nwl.cc> wrote:
> This fixes two issues with the provided example:
>
> - Add missing 'dev' keyword to second command.
> - Use a real IPv4 address instead of a bogus hex value since that will
> be rejected by get_addr_ipv4().
>
> Fixes: dbfb17a67f9c7 ("man: tc-csum.8: Add an example")
> Reported-by: Davide Caratti <dcaratti@redhat.com>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> Changes since v1:
> - Instead of using potentially valid IP addresses, use RFC 5737 ones.
Applied thanks
prev parent reply other threads:[~2017-01-30 4:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 11:59 [iproute PATCH v2] man: tc-csum.8: Fix example Phil Sutter
2017-01-30 4:26 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170129202609.6b2521a0@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).