netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [iproute PATCH v2] man: tc-csum.8: Fix example
@ 2017-01-28 11:59 Phil Sutter
  2017-01-30  4:26 ` Stephen Hemminger
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2017-01-28 11:59 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

This fixes two issues with the provided example:

- Add missing 'dev' keyword to second command.
- Use a real IPv4 address instead of a bogus hex value since that will
  be rejected by get_addr_ipv4().

Fixes: dbfb17a67f9c7 ("man: tc-csum.8: Add an example")
Reported-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
Changes since v1:
- Instead of using potentially valid IP addresses, use RFC 5737 ones.
---
 man/man8/tc-csum.8 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/man/man8/tc-csum.8 b/man/man8/tc-csum.8
index 3a64c82f09ba8..68e5610513a51 100644
--- a/man/man8/tc-csum.8
+++ b/man/man8/tc-csum.8
@@ -57,9 +57,9 @@ packets, both IP and UDP checksums have to be recalculated:
 .RS
 .EX
 # tc qdisc add dev eth0 ingress handle ffff:
-# tc filter add eth0 prio 1 protocol ip parent ffff: \\
-	u32 match ip src 192.168.1.100/32 flowid :1 \\
-	action pedit munge ip dst set 0x12345678 pipe \\
+# tc filter add dev eth0 prio 1 protocol ip parent ffff: \\
+	u32 match ip src 192.0.2.100/32 flowid :1 \\
+	action pedit munge ip dst set 198.51.100.1 pipe \\
 	csum ip and udp
 .EE
 .RE
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [iproute PATCH v2] man: tc-csum.8: Fix example
  2017-01-28 11:59 [iproute PATCH v2] man: tc-csum.8: Fix example Phil Sutter
@ 2017-01-30  4:26 ` Stephen Hemminger
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2017-01-30  4:26 UTC (permalink / raw)
  To: Phil Sutter; +Cc: netdev

On Sat, 28 Jan 2017 12:59:10 +0100
Phil Sutter <phil@nwl.cc> wrote:

> This fixes two issues with the provided example:
> 
> - Add missing 'dev' keyword to second command.
> - Use a real IPv4 address instead of a bogus hex value since that will
>   be rejected by get_addr_ipv4().
> 
> Fixes: dbfb17a67f9c7 ("man: tc-csum.8: Add an example")
> Reported-by: Davide Caratti <dcaratti@redhat.com>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> Changes since v1:
> - Instead of using potentially valid IP addresses, use RFC 5737 ones.

Applied thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-30  4:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-28 11:59 [iproute PATCH v2] man: tc-csum.8: Fix example Phil Sutter
2017-01-30  4:26 ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).