* [PATCH iproute2 1/1] tc: distinguish Add/Replace action operations.
@ 2017-01-22 13:55 Roman Mashak
2017-01-27 11:37 ` Phil Sutter
2017-01-30 4:27 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Roman Mashak @ 2017-01-22 13:55 UTC (permalink / raw)
To: stephen; +Cc: netdev, Roman Mashak, Jamal Hadi Salim
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
tc/m_action.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tc/m_action.c b/tc/m_action.c
index bb19df8..05ef07e 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -365,12 +365,18 @@ int print_action(const struct sockaddr_nl *who,
fprintf(fp, "Flushed table ");
tab_flush = 1;
} else {
- fprintf(fp, "deleted action ");
+ fprintf(fp, "Deleted action ");
}
}
- if (n->nlmsg_type == RTM_NEWACTION)
- fprintf(fp, "Added action ");
+ if (n->nlmsg_type == RTM_NEWACTION) {
+ if ((n->nlmsg_flags & NLM_F_CREATE) &&
+ !(n->nlmsg_flags & NLM_F_REPLACE)) {
+ fprintf(fp, "Added action ");
+ } else if (n->nlmsg_flags & NLM_F_REPLACE) {
+ fprintf(fp, "Replaced action ");
+ }
+ }
tc_print_action(fp, tb[TCA_ACT_TAB]);
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH iproute2 1/1] tc: distinguish Add/Replace action operations.
2017-01-22 13:55 [PATCH iproute2 1/1] tc: distinguish Add/Replace action operations Roman Mashak
@ 2017-01-27 11:37 ` Phil Sutter
2017-01-30 4:27 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Phil Sutter @ 2017-01-27 11:37 UTC (permalink / raw)
To: Roman Mashak; +Cc: stephen, netdev, Jamal Hadi Salim
On Sun, Jan 22, 2017 at 08:55:33AM -0500, Roman Mashak wrote:
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Acked-by: Phil Sutter <phil@nwl.cc>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2 1/1] tc: distinguish Add/Replace action operations.
2017-01-22 13:55 [PATCH iproute2 1/1] tc: distinguish Add/Replace action operations Roman Mashak
2017-01-27 11:37 ` Phil Sutter
@ 2017-01-30 4:27 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2017-01-30 4:27 UTC (permalink / raw)
To: Roman Mashak; +Cc: netdev, Jamal Hadi Salim
On Sun, 22 Jan 2017 08:55:33 -0500
Roman Mashak <mrv@mojatatu.com> wrote:
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
> ---
> tc/m_action.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-30 4:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-22 13:55 [PATCH iproute2 1/1] tc: distinguish Add/Replace action operations Roman Mashak
2017-01-27 11:37 ` Phil Sutter
2017-01-30 4:27 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).