From: Stephen Hemminger <stephen@networkplumber.org>
To: Nogah Frankel <nogahf@mellanox.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
roszenrami@gmail.com, jbenc@redhat.com,
sergei.shtylyov@cogentembedded.com, jiri@mellanox.com,
eladr@mellanox.com, idosch@mellanox.com, yotamg@mellanox.com,
ogerlitz@mellanox.com
Subject: Re: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat
Date: Sun, 29 Jan 2017 20:34:25 -0800 [thread overview]
Message-ID: <20170129203425.070a27d6@xeon-e3> (raw)
In-Reply-To: <1485434681-33947-3-git-send-email-nogahf@mellanox.com>
On Thu, 26 Jan 2017 14:44:39 +0200
Nogah Frankel <nogahf@mellanox.com> wrote:
> Extended stats are part of the RTM_GETSTATS method. This patch adds them
> to ifstat.
> While extended stats can come in many forms, we support only the
> rtnl_link_stats64 struct for them (which is the 64 bits version of struct
> rtnl_link_stats).
> We support stats in the main nesting level, or one lower.
> The extension can be called by its name or any shorten of it. If there is
> more than one matched, the first one will be picked.
>
> To get the extended stats the flag -x <stats type> is used.
It would be better if this command used 64 bit statistics transparently
like other tools in iproute2. Transparency is always better user experience.
next prev parent reply other threads:[~2017-01-30 4:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 12:44 [PATCH iproute2 v5 0/4] update ifstat for new stats Nogah Frankel
2017-01-26 12:44 ` [PATCH iproute2 v5 1/4] ifstat: Includes reorder Nogah Frankel
2017-01-26 12:44 ` [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat Nogah Frankel
2017-01-30 4:34 ` Stephen Hemminger [this message]
2017-02-02 8:53 ` Nogah Frankel
2017-02-03 18:07 ` Stephen Hemminger
2017-02-07 12:59 ` Nogah Frankel
2017-02-07 16:48 ` Stephen Hemminger
2017-01-26 12:44 ` [PATCH iproute2 v5 3/4] ifstat: Add "sw only" " Nogah Frankel
2017-01-26 12:44 ` [PATCH iproute2 v5 4/4] ifstat: Add xstat to ifstat man page Nogah Frankel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170129203425.070a27d6@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jbenc@redhat.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=roszenrami@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).