From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: Avoid receiving packets with an l3mdev on unbound UDP sockets Date: Mon, 30 Jan 2017 15:01:14 -0500 (EST) Message-ID: <20170130.150114.249644236631741676.davem@davemloft.net> References: <1485453744-5120-1-git-send-email-rshearma@brocade.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: rshearma@brocade.com, netdev@vger.kernel.org To: dsa@cumulusnetworks.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:37586 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754342AbdA3ULE (ORCPT ); Mon, 30 Jan 2017 15:11:04 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Mon, 30 Jan 2017 11:52:01 -0700 > On 1/26/17 11:02 AM, Robert Shearman wrote: >> Packets arriving in a VRF currently are delivered to UDP sockets that >> aren't bound to any interface. TCP defaults to not delivering packets >> arriving in a VRF to unbound sockets. IP route lookup and socket >> transmit both assume that unbound means using the default table and >> UDP applications that haven't been changed to be aware of VRFs may not >> function correctly in this case since they may not be able to handle >> overlapping IP address ranges, or be able to send packets back to the >> original sender if required. >> >> So add a sysctl, udp_l3mdev_accept, to control this behaviour with it >> being analgous to the existing tcp_l3mdev_accept, namely to allow a >> process to have a VRF-global listen socket. Have this default to off >> as this is the behaviour that users will expect, given that there is >> no explicit mechanism to set unmodified VRF-unaware application into a >> default VRF. >> >> Signed-off-by: Robert Shearman >> --- >> I've targetted this for the net tree because I believe the expected >> behaviour is different enough from the current behaviour to be >> considered a bug. However, this should also apply to the net-next tree >> as-is if this not deemed a bug. > > Does not apply to net-next; collision in sysctl_net_ipv4.c > > As for the code change, I have updated my unit tests and they all pass with this patch. Not sure why I marked my version as not working last November, but it is all good now. > > Acked-by: David Ahern > Tested-by: David Ahern The conflict was easy enough to fix up, so I did it myself. Applied to net-next, thanks.