From: David Miller <davem@davemloft.net>
To: David.Laight@ACULAB.COM
Cc: tariqt@mellanox.com, netdev@vger.kernel.org, eranbe@mellanox.com,
lariel@mellanox.com
Subject: Re: [PATCH net-next V3 5/8] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool
Date: Mon, 30 Jan 2017 15:25:32 -0500 (EST) [thread overview]
Message-ID: <20170130.152532.370636093483999005.davem@davemloft.net> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DB0273B7E@AcuExch.aculab.com>
From: David Laight <David.Laight@ACULAB.COM>
Date: Mon, 30 Jan 2017 14:00:28 +0000
> From: Tariq Toukan
>> Sent: 29 January 2017 16:56
>> From: Ariel Levkovich <lariel@mellanox.com>
>>
>> This feature will allow the user to disable auto negotiation
>> on the port for mlx4 devices while setting the speed is limited
>> to 1GbE speeds.
>> Other speeds will not be accepted in autoneg off mode.
>
> What is the rationale behind this change?
Because it's an ethtool user feature we've had to two decades
and it allows the user greater control over the link state.
> When I was writing ethernet drivers it was always better to
> leave autonegotiation enabled with restricted modes than to
> fix the speed.
Nothing about this change effects this. The user is just given
the ability to turn autonegotiation off if they wish to do so.
next prev parent reply other threads:[~2017-01-30 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 16:56 [PATCH net-next V3 0/8] mlx4 misc improvements Tariq Toukan
2017-01-29 16:56 ` [PATCH net-next V3 1/8] net/mlx4: Replace ENOSYS with better fitting error codes Tariq Toukan
2017-01-29 16:56 ` [PATCH net-next V3 2/8] net/mlx4_core: Device revision support Tariq Toukan
2017-01-29 16:56 ` [PATCH net-next V3 3/8] net/mlx4_core: Add resource alloc/dealloc debugging Tariq Toukan
2017-01-29 16:56 ` [PATCH net-next V3 4/8] net/mlx4_core: Get num_tc using netdev_get_num_tc Tariq Toukan
2017-01-29 16:56 ` [PATCH net-next V3 5/8] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool Tariq Toukan
2017-01-30 14:00 ` David Laight
2017-01-30 20:25 ` David Miller [this message]
2017-01-29 16:56 ` [PATCH net-next V3 6/8] net/mlx4_en: Pass user MTU value to Firmware at set port command Tariq Toukan
2017-01-29 16:56 ` [PATCH net-next V3 7/8] net/mlx4_en: Check the enabling mtu flag in SET_PORT wrapper flow Tariq Toukan
2017-01-29 16:56 ` [PATCH net-next V3 8/8] net/mlx4_en: Check the enabling pptx/pprx flags " Tariq Toukan
2017-01-30 20:27 ` [PATCH net-next V3 0/8] mlx4 misc improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130.152532.370636093483999005.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=eranbe@mellanox.com \
--cc=lariel@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).