From: David Miller <davem@davemloft.net>
To: tariqt@mellanox.com
Cc: netdev@vger.kernel.org, eranbe@mellanox.com, jackm@dev.mellanox.co.il
Subject: Re: [PATCH net] net/mlx4_core: Avoid command timeouts during VF driver device shutdown
Date: Mon, 30 Jan 2017 15:45:40 -0500 (EST) [thread overview]
Message-ID: <20170130.154540.1823715181237721096.davem@davemloft.net> (raw)
In-Reply-To: <1485781905-1511-1-git-send-email-tariqt@mellanox.com>
From: Tariq Toukan <tariqt@mellanox.com>
Date: Mon, 30 Jan 2017 15:11:45 +0200
> From: Jack Morgenstein <jackm@dev.mellanox.co.il>
>
> Some Hypervisors detach VFs from VMs by instantly causing an FLR event
> to be generated for a VF.
>
> In the mlx4 case, this will cause that VF's comm channel to be disabled
> before the VM has an opportunity to invoke the VF device's "shutdown"
> method.
>
> The result is that the VF driver on the VM will experience a command
> timeout during the shutdown process when the Hypervisor does not deliver
> a command-completion event to the VM.
>
> To avoid FW command timeouts on the VM when the driver's shutdown method
> is invoked, we detect the absence of the VF's comm channel at the very
> start of the shutdown process. If the comm-channel has already been
> disabled, we cause all FW commands during the device shutdown process to
> immediately return success (and thus avoid all command timeouts).
>
> Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Applied, thanks.
prev parent reply other threads:[~2017-01-30 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 13:11 [PATCH net] net/mlx4_core: Avoid command timeouts during VF driver device shutdown Tariq Toukan
2017-01-30 20:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130.154540.1823715181237721096.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=jackm@dev.mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).