From: David Miller <davem@davemloft.net>
To: ecree@solarflare.com
Cc: colin.king@canonical.com, linux-net-drivers@solarflare.com,
bkenward@solarflare.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][net-next] sfc: fix an off-by-one compare on an array size
Date: Tue, 31 Jan 2017 12:26:02 -0500 (EST) [thread overview]
Message-ID: <20170131.122602.1280692272369236886.davem@davemloft.net> (raw)
In-Reply-To: <0a30579a-b0e4-11cd-8613-735c143061e1@solarflare.com>
From: Edward Cree <ecree@solarflare.com>
Date: Tue, 31 Jan 2017 16:37:10 +0000
> On 31/01/17 16:30, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> encap_type should be checked to see if it is greater or equal to
>> the size of array map to fix an off-by-one array size check. This
>> fixes an array overrun read as detected by static analysis by
>> CoverityScan, CID#1398883 ("Out-of-bounds-read")
>>
>> Fixes: 9b41080125176841e ("sfc: insert catch-all filters for encapsulated traffic")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Good catch.
>
> Acked-by: Edward Cree <ecree@solarflare.com>
Applied, thanks everyone.
prev parent reply other threads:[~2017-01-31 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 16:30 [PATCH][net-next] sfc: fix an off-by-one compare on an array size Colin King
2017-01-31 16:37 ` Edward Cree
2017-01-31 17:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131.122602.1280692272369236886.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bkenward@solarflare.com \
--cc=colin.king@canonical.com \
--cc=ecree@solarflare.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox