From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: zajec5@gmail.com, jon.mason@broadcom.com, nbd@openwrt.org,
netdev@vger.kernel.org, rafal@milecki.pl
Subject: Re: [PATCH V2 3/3] net: bgmac: use PHY subsystem for initializing PHY
Date: Tue, 31 Jan 2017 13:16:04 -0500 (EST) [thread overview]
Message-ID: <20170131.131604.1471461660602159004.davem@davemloft.net> (raw)
In-Reply-To: <20170131.131452.553487511329277271.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 31 Jan 2017 13:14:52 -0500 (EST)
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 31 Jan 2017 10:06:34 -0800
>
>> On 01/31/2017 10:04 AM, David Miller wrote:
>>>
>>> This entire series is being held up because there is still questions about
>>> whether this is programming the internal PHYs and therefore whether the
>>> code should be placed elsewhere.
>>>
>>> Can we please move the discussion forward?
>>
>> The patches are good as-is, we can resolve the PHY programming later on
>> when we have figured out the details of the 4749 chip we derailed on.
>
> Ok great, series applied, thanks.
Actually, reverted, I get build failures:
[davem@dhcp-10-15-49-210 net-next]$ make -s -j8
DESCEND objtool
Setup is 17084 bytes (padded to 17408 bytes).
System is 10211 kB
CRC 68863231
Kernel: arch/x86/boot/bzImage is ready (#139)
ERROR: "bgmac_alloc" [drivers/net/ethernet/broadcom/bgmac-platform.ko] undefined!
ERROR: "bgmac_alloc" [drivers/net/ethernet/broadcom/bgmac-bcma.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1196: recipe for target 'modules' failed
make: *** [modules] Error 2
next prev parent reply other threads:[~2017-01-31 18:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 21:08 [PATCH V2 0/3] net-next: use one struct bgmac & add PHY support Rafał Miłecki
2017-01-28 21:08 ` [PATCH V2 1/3] net: bgmac: allocate struct bgmac just once & don't copy it Rafał Miłecki
2017-01-28 23:40 ` kbuild test robot
2017-01-29 20:03 ` Rafał Miłecki
2017-01-31 18:07 ` Florian Fainelli
2017-01-28 21:08 ` [PATCH V2 2/3] net: bgmac: drop struct bcma_mdio we don't need anymore Rafał Miłecki
2017-01-31 18:07 ` Florian Fainelli
2017-01-28 21:08 ` [PATCH V2 3/3] net: bgmac: use PHY subsystem for initializing PHY Rafał Miłecki
2017-01-29 3:08 ` Florian Fainelli
2017-01-29 20:14 ` Rafał Miłecki
[not found] ` <03584f21-6ea2-a6ea-3100-cf5b1ead4f0f@gmail.com>
2017-01-29 21:31 ` Rafał Miłecki
2017-01-29 22:36 ` Florian Fainelli
2017-01-30 7:02 ` Rafał Miłecki
2017-01-30 18:29 ` Florian Fainelli
2017-01-30 16:07 ` Jon Mason
2017-01-31 18:04 ` David Miller
2017-01-31 18:06 ` Florian Fainelli
2017-01-31 18:14 ` David Miller
2017-01-31 18:16 ` David Miller [this message]
2017-01-31 18:17 ` Rafał Miłecki
2017-01-31 18:07 ` Florian Fainelli
2017-01-31 18:37 ` [PATCH V3 0/3] net-next: use one struct bgmac & add PHY support Rafał Miłecki
2017-01-31 18:37 ` [PATCH V3 1/3] net: bgmac: allocate struct bgmac just once & don't copy it Rafał Miłecki
2017-01-31 18:37 ` [PATCH V3 2/3] net: bgmac: drop struct bcma_mdio we don't need anymore Rafał Miłecki
2017-01-31 18:37 ` [PATCH V3 3/3] net: bgmac: use PHY subsystem for initializing PHY Rafał Miłecki
2017-01-31 19:03 ` [PATCH V3 0/3] net-next: use one struct bgmac & add PHY support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131.131604.1471461660602159004.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jon.mason@broadcom.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).