From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH V2 3/3] net: bgmac: use PHY subsystem for initializing PHY Date: Tue, 31 Jan 2017 13:16:04 -0500 (EST) Message-ID: <20170131.131604.1471461660602159004.davem@davemloft.net> References: <20170131.130429.1477789092223900995.davem@davemloft.net> <1daad20f-f794-3c10-d020-fa08dbf228c2@gmail.com> <20170131.131452.553487511329277271.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: zajec5@gmail.com, jon.mason@broadcom.com, nbd@openwrt.org, netdev@vger.kernel.org, rafal@milecki.pl To: f.fainelli@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:40312 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbdAaSQZ (ORCPT ); Tue, 31 Jan 2017 13:16:25 -0500 In-Reply-To: <20170131.131452.553487511329277271.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: From: David Miller Date: Tue, 31 Jan 2017 13:14:52 -0500 (EST) > From: Florian Fainelli > Date: Tue, 31 Jan 2017 10:06:34 -0800 > >> On 01/31/2017 10:04 AM, David Miller wrote: >>> >>> This entire series is being held up because there is still questions about >>> whether this is programming the internal PHYs and therefore whether the >>> code should be placed elsewhere. >>> >>> Can we please move the discussion forward? >> >> The patches are good as-is, we can resolve the PHY programming later on >> when we have figured out the details of the 4749 chip we derailed on. > > Ok great, series applied, thanks. Actually, reverted, I get build failures: [davem@dhcp-10-15-49-210 net-next]$ make -s -j8 DESCEND objtool Setup is 17084 bytes (padded to 17408 bytes). System is 10211 kB CRC 68863231 Kernel: arch/x86/boot/bzImage is ready (#139) ERROR: "bgmac_alloc" [drivers/net/ethernet/broadcom/bgmac-platform.ko] undefined! ERROR: "bgmac_alloc" [drivers/net/ethernet/broadcom/bgmac-bcma.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1196: recipe for target 'modules' failed make: *** [modules] Error 2