From: Richard Cochran <richardcochran@gmail.com>
To: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Cc: David Laight <David.Laight@ACULAB.COM>,
"Kalluru, Sudarsana" <Sudarsana.Kalluru@cavium.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] qede: Add driver support for PTP.
Date: Tue, 31 Jan 2017 15:53:18 +0100 [thread overview]
Message-ID: <20170131145318.GA18274@localhost.localdomain> (raw)
In-Reply-To: <BL2PR07MB23068B30A71CB67A8DE673E48D4A0@BL2PR07MB2306.namprd07.prod.outlook.com>
On Tue, Jan 31, 2017 at 02:31:41PM +0000, Mintz, Yuval wrote:
> I feel like I'm missing something. Again.
> I thought the reasonable rate of rate-adjustment is once a second,
> which doesn't make it 'hot' in any way.
> In which scenario would we frequently encounter this configuration?
The Sync message rate is not 1 per second, but rather the interval is
specified by the PTP profile as 2^N seconds, -128 <= N < 128.
This is called the logSyncInterval, and in the Telecom profile [1] for
example, N = -4.
Anyhow, as far the original question goes, maybe you could have the
specific HW driver pass its adjfreq function pointer into the generic
driver and let the generic driver copy it directly into the
ptp_clock_info.
Just an idea.
Thanks,
Richard
1. T-REC-G.8275.1-201407
next prev parent reply other threads:[~2017-01-31 15:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 7:28 [PATCH net-next v2 0/2] qed*: Add support for PTP Sudarsana Kalluru
2017-01-29 7:28 ` [PATCH net-next v2 1/2] qed: Add infrastructure for PTP support Sudarsana Kalluru
2017-01-29 8:32 ` kbuild test robot
2017-01-29 15:28 ` Richard Cochran
2017-01-29 15:31 ` Richard Cochran
2017-01-29 17:26 ` Mintz, Yuval
2017-01-29 20:51 ` Richard Cochran
2017-01-29 21:36 ` Mintz, Yuval
2017-01-30 13:26 ` Richard Cochran
2017-01-30 18:00 ` Mintz, Yuval
2017-01-29 7:28 ` [PATCH net-next v2 2/2] qede: Add driver support for PTP Sudarsana Kalluru
2017-01-29 15:35 ` Richard Cochran
2017-01-29 17:30 ` Mintz, Yuval
2017-01-29 21:02 ` Richard Cochran
2017-01-29 21:40 ` Mintz, Yuval
2017-01-30 14:34 ` David Laight
2017-01-30 17:55 ` Mintz, Yuval
2017-01-31 10:03 ` David Laight
2017-01-31 14:31 ` Mintz, Yuval
2017-01-31 14:53 ` Richard Cochran [this message]
2017-01-31 15:08 ` Mintz, Yuval
2017-01-31 17:43 ` Richard Cochran
2017-01-29 15:09 ` [PATCH net-next v2 0/2] qed*: Add " Richard Cochran
2017-01-29 17:23 ` Mintz, Yuval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131145318.GA18274@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=Sudarsana.Kalluru@cavium.com \
--cc=Yuval.Mintz@cavium.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).