From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Simon Horman <horms+renesas@verge.net.au>,
netdev@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: [PATCH 1/2] sh_eth: align usage of sh_eth_modify() with rest of driver
Date: Wed, 1 Feb 2017 15:41:54 +0100 [thread overview]
Message-ID: <20170201144155.17123-2-niklas.soderlund+renesas@ragnatech.se> (raw)
In-Reply-To: <20170201144155.17123-1-niklas.soderlund+renesas@ragnatech.se>
To be consistent with the rest of the driver when setting bits using
sh_eth_modify() the same bit should also be cleared. This have no
functional change and should have been done from the start.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 2f08d2735fe25e4d..f9134c818ac6ef53 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -3271,7 +3271,7 @@ static int sh_eth_wol_setup(struct net_device *ndev)
sh_eth_write(ndev, EESIPR_ECIIP, EESIPR);
/* Enable MagicPacket */
- sh_eth_modify(ndev, ECMR, 0, ECMR_MPDE);
+ sh_eth_modify(ndev, ECMR, ECMR_MPDE, ECMR_MPDE);
/* Increased clock usage so device won't be suspended */
clk_enable(mdp->clk);
--
2.11.0
next prev parent reply other threads:[~2017-02-01 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 14:41 [PATCH 0/2] sh_eth: fixes for MagicPacket handling Niklas Söderlund
2017-02-01 14:41 ` Niklas Söderlund [this message]
2017-02-01 15:55 ` [PATCH 1/2] sh_eth: align usage of sh_eth_modify() with rest of driver Sergei Shtylyov
2017-02-01 14:41 ` [PATCH 2/2] sh_eth: fix wakeup event reporting from MagicPacket Niklas Söderlund
2017-02-01 15:56 ` Sergei Shtylyov
2017-02-01 15:56 ` Sergei Shtylyov
2017-02-01 17:54 ` [PATCH 0/2] sh_eth: fixes for MagicPacket handling David Miller
2017-02-01 18:06 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201144155.17123-2-niklas.soderlund+renesas@ragnatech.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).