From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
nikolay@cumulusnetworks.com, tgraf@suug.ch,
hannes@stressinduktion.org, jbenc@redhat.com, pshelar@ovn.org,
dsa@cumulusnetworks.com, hadi@mojatatu.com
Subject: Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support
Date: Thu, 02 Feb 2017 20:50:53 -0500 (EST) [thread overview]
Message-ID: <20170202.205053.1531692095462887882.davem@davemloft.net> (raw)
In-Reply-To: <1485932395-58422-1-git-send-email-roopa@cumulusnetworks.com>
I see a lot of "complexity of bridging layer" pushback on these
changes, and I understand where that is coming from.
But really this isn't even, at a high level, really a bridging change.
What it's doing is making lwtunnel objects more useful.
Now that we have lightweight tunnels and netdevs, we will constantly
have this struggle trying to figure out how to make lwtunnel objects
apply to the same cases that netdevs currently only work for.
Because once you run into one of these situations where only netdevs
work, you are screwed and lwtunnels and their scalability benefit
might as well not even exist.
To be completely honest, in this case it's pretty clear:
1) It makes vxlan lwtunnel objects more usable for bridges.
2) It does not make lwtunnels more bloated or consume more memory
or cpu in the dataplane fast paths.
3) It makes uptake of lwtunnels higher, because they can be used
in more places.
So I think this change is a win and a move forward.
next prev parent reply other threads:[~2017-02-03 1:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 6:59 [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support Roopa Prabhu
2017-02-01 6:59 ` [PATCH net-next v2 1/5] ip_tunnels: new IP_TUNNEL_INFO_BRIDGE flag for ip_tunnel_info mode Roopa Prabhu
2017-02-01 6:59 ` [PATCH net-next v2 2/5] vxlan: support fdb and learning in COLLECT_METADATA mode Roopa Prabhu
2017-02-11 4:05 ` Joe Stringer
2017-02-11 4:55 ` Roopa Prabhu
2017-02-01 6:59 ` [PATCH net-next v2 3/5] bridge: uapi: add per vlan tunnel info Roopa Prabhu
2017-02-01 6:59 ` [PATCH net-next v2 4/5] bridge: per vlan dst_metadata netlink support Roopa Prabhu
2017-02-01 6:59 ` [PATCH net-next v2 5/5] bridge: vlan dst_metadata hooks in ingress and egress paths Roopa Prabhu
2017-02-02 1:23 ` [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support Alexei Starovoitov
2017-02-02 1:59 ` David Ahern
2017-02-02 4:02 ` Roopa Prabhu
2017-02-02 4:04 ` Stephen Hemminger
2017-02-02 5:07 ` Roopa Prabhu
2017-02-02 5:58 ` Roopa Prabhu
2017-02-02 7:06 ` Stephen Hemminger
2017-02-02 14:33 ` Roopa Prabhu
2017-02-03 1:50 ` David Miller [this message]
2017-02-03 6:06 ` Roopa Prabhu
2017-02-03 20:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202.205053.1531692095462887882.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=hadi@mojatatu.com \
--cc=hannes@stressinduktion.org \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pshelar@ovn.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).