From: David Miller <davem@davemloft.net>
To: daniel@iogearbox.net
Cc: rostedt@goodmis.org, ast@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] trace: rename trace_print_hex_seq arg and add kdoc
Date: Fri, 03 Feb 2017 15:50:45 -0500 (EST) [thread overview]
Message-ID: <20170203.155045.1099357457146606258.davem@davemloft.net> (raw)
In-Reply-To: <fefa5048a9834e7857fa399dc800054d4cebdd31.1486050724.git.daniel@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Thu, 2 Feb 2017 17:09:54 +0100
> Steven suggested to improve trace_print_hex_seq() a bit after commit
> 2acae0d5b0f7 ("trace: add variant without spacing in trace_print_hex_seq")
> in two ways: i) by adding a kdoc comment for the helper function
> itself and ii) by renaming 'spacing' argument into 'concatenate'
> to better denote that we don't add spaces between each hex bytes.
>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
> [ Sending as follow-up as original one is in net-next. ]
Applied, thanks Daniel.
prev parent reply other threads:[~2017-02-03 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 16:09 [PATCH net-next] trace: rename trace_print_hex_seq arg and add kdoc Daniel Borkmann
2017-02-03 20:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203.155045.1099357457146606258.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).