From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jbacik@fb.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: clear pfmemalloc on outgoing skb
Date: Fri, 03 Feb 2017 16:24:08 -0500 (EST) [thread overview]
Message-ID: <20170203.162408.851464918447697481.davem@davemloft.net> (raw)
In-Reply-To: <1486096808.21871.67.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 02 Feb 2017 20:40:08 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Josef Bacik diagnosed following problem :
>
> I was seeing random disconnects while testing NBD over loopback.
> This turned out to be because NBD sets pfmemalloc on it's socket,
> however the receiving side is a user space application so does not
> have pfmemalloc set on its socket. This means that
> sk_filter_trim_cap will simply drop this packet, under the
> assumption that the other side will simply retransmit. Well we do
> retransmit, and then the packet is just dropped again for the same
> reason.
>
> It seems the better way to address this problem is to clear pfmemalloc
> in the TCP transmit path. pfmemalloc strict control really makes sense
> on the receive path.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Acked-by: Josef Bacik <jbacik@fb.com>
Applied.
prev parent reply other threads:[~2017-02-03 21:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 21:04 [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's Josef Bacik
2017-02-01 23:38 ` Eric Dumazet
2017-02-01 23:57 ` Eric Dumazet
2017-02-02 2:13 ` [PATCH net-next] net: remove useless pfmemalloc setting Eric Dumazet
2017-02-03 4:03 ` David Miller
2017-02-02 2:46 ` [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's Eric Dumazet
2017-02-02 15:56 ` Josef Bacik
2017-02-02 17:06 ` Eric Dumazet
2017-02-02 20:49 ` Josef Bacik
2017-02-03 4:40 ` [PATCH net-next] tcp: clear pfmemalloc on outgoing skb Eric Dumazet
2017-02-03 21:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203.162408.851464918447697481.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jbacik@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).