netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Eric Dumazet <edumazet@google.com>
Cc: kbuild-all@01.org, "David S . Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next 6/9] ep93xx_eth: add GRO support
Date: Sun, 5 Feb 2017 04:47:20 +0800	[thread overview]
Message-ID: <201702050406.Mb15e36Q%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170204182038.3752-7-edumazet@google.com>

[-- Attachment #1: Type: text/plain, Size: 4022 bytes --]

Hi Eric,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-get-rid-of-most-__napi_complete-usages/20170205-022748
config: arm-ep93xx_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/cirrus/ep93xx_eth.c: In function 'ep93xx_poll':
>> drivers/net/ethernet/cirrus/ep93xx_eth.c:319:5: warning: 'rx' is used uninitialized in this function [-Wuninitialized]
     rx = ep93xx_rx(dev, rx, budget);
     ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/rx +319 drivers/net/ethernet/cirrus/ep93xx_eth.c

1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  303  		}
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  304  
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  305  err:
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  306  		ep->rx_pointer = (entry + 1) & (RX_QUEUE_ENTRIES - 1);
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  307  		processed++;
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  308  	}
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  309  
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03  310  	return processed;
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  311  }
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  312  
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03  313  static int ep93xx_poll(struct napi_struct *napi, int budget)
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  314  {
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03  315  	struct ep93xx_priv *ep = container_of(napi, struct ep93xx_priv, napi);
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03  316  	struct net_device *dev = ep->dev;
7b8cc50a drivers/net/ethernet/cirrus/ep93xx_eth.c Eric Dumazet      2017-02-04  317  	int rx;
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  318  
bea3348e drivers/net/arm/ep93xx_eth.c             Stephen Hemminger 2007-10-03 @319  	rx = ep93xx_rx(dev, rx, budget);
7b8cc50a drivers/net/ethernet/cirrus/ep93xx_eth.c Eric Dumazet      2017-02-04  320  	if ((rx < budget) && napi_complete_done(napi, rx)) {
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  321  		spin_lock_irq(&ep->rx_lock);
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  322  		wrl(ep, REG_INTEN, REG_INTEN_TX | REG_INTEN_RX);
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  323  		spin_unlock_irq(&ep->rx_lock);
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  324  	}
1d22e05d drivers/net/arm/ep93xx_eth.c             Lennert Buytenhek 2006-09-22  325  
1827d2e9 drivers/net/arm/ep93xx_eth.c             David S. Miller   2010-05-03  326  	if (rx) {
1827d2e9 drivers/net/arm/ep93xx_eth.c             David S. Miller   2010-05-03  327  		wrw(ep, REG_RXDENQ, rx);

:::::: The code at line 319 was first introduced by commit
:::::: bea3348eef27e6044b6161fd04c3152215f96411 [NET]: Make NAPI polling independent of struct net_device objects.

:::::: TO: Stephen Hemminger <shemminger@linux-foundation.org>
:::::: CC: David S. Miller <davem@sunset.davemloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 15664 bytes --]

  reply	other threads:[~2017-02-04 20:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-04 18:20 [PATCH net-next 0/9] net: get rid of most __napi_complete() usages Eric Dumazet
2017-02-04 18:20 ` [PATCH net-next 1/9] 8139too: use napi_complete_done() Eric Dumazet
2017-02-04 18:20 ` [PATCH net-next 2/9] 8139cp: " Eric Dumazet
2017-02-04 18:20 ` [PATCH net-next 3/9] epic100: " Eric Dumazet
2017-02-04 18:20 ` [PATCH net-next 4/9] amd8111e: add GRO support Eric Dumazet
2017-02-04 18:20 ` [PATCH net-next 5/9] pcnet32: use napi_complete_done() Eric Dumazet
2017-02-04 18:20 ` [PATCH net-next 6/9] ep93xx_eth: add GRO support Eric Dumazet
2017-02-04 20:47   ` kbuild test robot [this message]
2017-02-04 18:20 ` [PATCH net-next 7/9] skge: use napi_complete_done() Eric Dumazet
2017-02-04 21:44   ` Stephen Hemminger
2017-02-04 22:16     ` Eric Dumazet
2017-02-04 18:20 ` [PATCH net-next 8/9] ks8695net: add GRO support Eric Dumazet
2017-02-04 18:20 ` [PATCH net-next 9/9] qla3xxx: " Eric Dumazet
2017-02-04 22:17 ` [PATCH net-next 0/9] net: get rid of most __napi_complete() usages Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201702050406.Mb15e36Q%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kbuild-all@01.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).