From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Add watchdog interrupt handler
Date: Sun, 5 Feb 2017 17:52:59 +0100 [thread overview]
Message-ID: <20170205165259.GB26564@lunn.ch> (raw)
In-Reply-To: <6936eb05-bec7-a898-6dae-875eda888ce1@gmail.com>
> > +static irqreturn_t mv88e6xxx_g2_watchdog_thread_fn(int irq, void *dev_id)
> > +{
> > + u16 reg;
> > +
> > + struct mv88e6xxx_chip *chip = dev_id;
> > +
> > + mv88e6xxx_g2_read(chip, GLOBAL2_WDOG_CONTROL, ®);
> > +
> > + dev_info(chip->dev, "Watchdog event: %04x", reg);
>
> Should this be 0x%04x just to illustrate the value is hexadecimal? And
Yes, the prefix would make sense.
> should this be dev_info_once()?
Since the next action is to disable the interrupt, and there is no
code path to reenable it, _once does not seem needed. And if for some
reason the kernel log is spammed with these messages, i want to
know. It means my interrupt handling code is badly broken!
Andrew
next prev parent reply other threads:[~2017-02-05 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 20:38 [PATCH net-next] net: dsa: mv88e6xxx: Add watchdog interrupt handler Andrew Lunn
2017-02-04 21:09 ` Vivien Didelot
2017-02-04 23:31 ` Andrew Lunn
2017-02-05 2:33 ` Florian Fainelli
2017-02-05 16:52 ` Andrew Lunn [this message]
2017-02-05 18:31 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170205165259.GB26564@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).