From: David Miller <davem@davemloft.net>
To: mkl@pengutronix.de
Cc: netdev@vger.kernel.org, kernel@pengutronix.de, linux-can@vger.kernel.org
Subject: Re: pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06
Date: Mon, 06 Feb 2017 11:12:59 -0500 (EST) [thread overview]
Message-ID: <20170206.111259.2261971436931731059.davem@davemloft.net> (raw)
In-Reply-To: <2b600a5b-f928-fe73-5b30-8b2fc1398068@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Mon, 6 Feb 2017 15:50:48 +0100
> this is a pull request of 16 patches for net-next/master.
>
> The first two patches by David Jander and me add the rx-offload
> framework for CAN devices to the kernel. The remaining 14 patches
> convert the flexcan driver to make use of it.
Pulled, but I wonder if your comparisons does the right thing when the
counters overflow.
I think you need to do the same thing we do for TCP sequence number
comparisons and code it like:
static inline bool before(__u32 seq1, __u32 seq2)
{
return (__s32)(seq1-seq2) < 0;
}
next prev parent reply other threads:[~2017-02-06 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 14:50 pull-request: can-next 2017-02-06 Marc Kleine-Budde
2017-02-06 16:12 ` David Miller [this message]
2017-02-06 16:43 ` pull-request: can-next 2017-02-06,pull-request: " Marc Kleine-Budde
2017-02-06 16:59 ` pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06,Re: " David Miller
2017-02-09 9:52 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206.111259.2261971436931731059.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).