From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harald Welte Subject: Re: [PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find_dev Date: Mon, 6 Feb 2017 14:55:12 +0100 Message-ID: <20170206135512.sbxvkbe3hzgnwwjt@nataraja> References: <20170130163713.17524-1-aschultz@tpip.net> <20170130163713.17524-3-aschultz@tpip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pablo Neira , netdev@vger.kernel.org, Lionel Gauthier , openbsc@lists.osmocom.org To: Andreas Schultz Return-path: Received: from ganesha.gnumonks.org ([213.95.27.120]:58531 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753249AbdBFOEj (ORCPT ); Mon, 6 Feb 2017 09:04:39 -0500 Content-Disposition: inline In-Reply-To: <20170130163713.17524-3-aschultz@tpip.net> Sender: netdev-owner@vger.kernel.org List-ID: Hi Andreas, On Mon, Jan 30, 2017 at 05:37:09PM +0100, Andreas Schultz wrote: > Both function are always used together with the final goal to > get the gtp_dev. This simplifies the code by merging them together. Ok, some code restructuring / unification, seems useful. However: > - netdev_dbg(dev, "GTPv0-U: update tunnel id = %llx (pdp %p)\n", > - pctx->u.v0.tid, pctx); > + pr_debug("GTPv0-U: update tunnel id = %llx (pdp %p)\n", > + pctx->u.v0.tid, pctx); (and other related changes) appear to be purely cosmetic and should thus be unrelated to the function merging described in the change log message. -- - Harald Welte http://netfilter.org/ ============================================================================ "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie