From: Harald Welte <laforge@gnumonks.org>
To: Andreas Schultz <aschultz@tpip.net>
Cc: Pablo Neira <pablo@netfilter.org>,
netdev@vger.kernel.org,
Lionel Gauthier <Lionel.Gauthier@eurecom.fr>,
openbsc@lists.osmocom.org
Subject: Re: [PATCH net-next v2 4/6] gtp: consolidate pdp context destruction into helper
Date: Mon, 6 Feb 2017 14:58:59 +0100 [thread overview]
Message-ID: <20170206135859.mq6pidofidnps2q6@nataraja> (raw)
In-Reply-To: <20170130163713.17524-5-aschultz@tpip.net>
Hi Andreas,
On Mon, Jan 30, 2017 at 05:37:11PM +0100, Andreas Schultz wrote:
> Consolidate duplicate code into helper.
Makes complete sense.
However:
> +static void pdp_context_delete(struct pdp_ctx *pctx);
> +
why introduce the forward-declaration and then define the function
further down in the file? I think in general, it is preferred to put
helper functions on top, before their first use, so forward declarations
can be avoided? Particularly if the helper function doesn't call any
other functions that are not yet declared at this point.
Please note the above might just be my personal taste, not sure if
that's a general habit in the kernel networking code these days.
So with or without the re-ordering:
Acked-by: Harald Welte <laforge@gnumonks.org>
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
next prev parent reply other threads:[~2017-02-06 14:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 16:37 [PATCH net-next v2 0/6] gtp: misc improvements Andreas Schultz
2017-01-30 16:37 ` [PATCH net-next v2 1/6] gtp: make GTP sockets in gtp_newlink optional Andreas Schultz
2017-02-02 14:10 ` Pablo Neira Ayuso
2017-02-02 14:30 ` Andreas Schultz
2017-02-02 14:32 ` Pablo Neira Ayuso
2017-02-06 13:51 ` Harald Welte
2017-01-30 16:37 ` [PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find_dev Andreas Schultz
2017-02-06 13:55 ` Harald Welte
2017-02-13 14:13 ` Andreas Schultz
2017-02-13 14:51 ` Pablo Neira Ayuso
2017-01-30 16:37 ` [PATCH net-next v2 3/6] gtp: unify genl_find_pdp and prepare for per socket lookup Andreas Schultz
2017-02-02 14:19 ` Pablo Neira Ayuso
2017-02-02 14:27 ` Andreas Schultz
2017-02-02 14:31 ` Pablo Neira Ayuso
2017-02-06 13:56 ` Harald Welte
2017-01-30 16:37 ` [PATCH net-next v2 4/6] gtp: consolidate pdp context destruction into helper Andreas Schultz
2017-02-06 13:58 ` Harald Welte [this message]
2017-02-13 14:14 ` Andreas Schultz
2017-01-30 16:37 ` [PATCH net-next v2 5/6] gtp: add socket to pdp context Andreas Schultz
2017-02-02 13:56 ` Pablo Neira Ayuso
2017-02-02 14:12 ` Andreas Schultz
2017-02-02 14:28 ` Pablo Neira Ayuso
2017-02-02 14:38 ` Andreas Schultz
2017-02-02 14:46 ` Pablo Neira Ayuso
2017-02-02 15:07 ` Andreas Schultz
2017-02-06 14:04 ` Harald Welte
2017-01-30 16:37 ` [PATCH net-next v2 6/6] gtp: consolidate gtp socket rx path Andreas Schultz
2017-01-31 18:05 ` [PATCH net-next v2 0/6] gtp: misc improvements David Miller
2017-02-06 13:46 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206135859.mq6pidofidnps2q6@nataraja \
--to=laforge@gnumonks.org \
--cc=Lionel.Gauthier@eurecom.fr \
--cc=aschultz@tpip.net \
--cc=netdev@vger.kernel.org \
--cc=openbsc@lists.osmocom.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox