From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] sctp: avoid BUG_ON on sctp_wait_for_sndbuf Date: Tue, 07 Feb 2017 12:55:54 -0500 (EST) Message-ID: <20170207.125554.925905416124561370.davem@davemloft.net> References: <90df61dca0e882ccc175bcec200b341b171b7406.1486411622.git.marcelo.leitner@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, alex.popov@linux.com To: marcelo.leitner@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52880 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753345AbdBGRz4 (ORCPT ); Tue, 7 Feb 2017 12:55:56 -0500 In-Reply-To: <90df61dca0e882ccc175bcec200b341b171b7406.1486411622.git.marcelo.leitner@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Marcelo Ricardo Leitner Date: Mon, 6 Feb 2017 18:10:31 -0200 > Alexander Popov reported that an application may trigger a BUG_ON in > sctp_wait_for_sndbuf if the socket tx buffer is full, a thread is > waiting on it to queue more data and meanwhile another thread peels off > the association being used by the first thread. > > This patch replaces the BUG_ON call with a proper error handling. It > will return -EPIPE to the original sendmsg call, similarly to what would > have been done if the association wasn't found in the first place. > > Acked-by: Alexander Popov > Signed-off-by: Marcelo Ricardo Leitner > --- > Please consider this to -stable. Thanks Applied and queued up for -stable, thanks a lot.